Fil, wouldn't the other native implementations need updated as well before merging in the changes that are required for cordova-js?
On Mon, May 14, 2012 at 5:26 PM, Filip Maj <f...@adobe.com> wrote: > Hey all, > > Part of the 1.8 work was to change the accelerometer plugin to line it up > more with the way the Geolocation plugin was rewritten. Essentially: > > - store callback ids in the plugin for incoming requests > - privatize start() and stop() methods > - start and stop the accel listener based on how many callbacks are > waiting for accel data > > The Accel plugin now should implement only 3 actions: getAcceleration, > addWatch, clearWatch. The plugin should handle calling start() and stop() > privately on its own. This also eliminates the awkward "getTimeout" and > "setTimeout" actions, and now we are ensured that the accelerometer plugin > stops as soon as possible (namely, when no callbacks in JS are waiting for > acceleration values), instead of waiting for the timeout period to expire. > > I added a few extra things to the android plugin rewrite as well, mainly > checking for accuracy level before returning values to the web view. > > If any Android maintainers want to take a look at the rewrite, please have > a look at the 463 branch on the Apache git repo [1]. Would love feedback > if you have the time to look it over. > > I will be merging it later this week unless someone has any issues with it. > > Thanks, > Fil > > [1] > http://git-wip-us.apache.org/repos/asf?p=incubator-cordova-android.git;a=sh > ortlog;h=refs/heads/463 >
