GitHub user becka11y opened a pull request:
https://github.com/apache/incubator-cordova-ios/pull/20
Fixes CB-819 fail callback not invoked - code review
Problem was that on iPad when popover controller is used,
the fail callback was not getting called when the popover was
dismissed w/o picking an image. Added a delay to the callback to JavaScript
since the app will hang if the callback contains a JavaScript alert.
Also removed clause to close popover from imagePickerDidCancel
because that method is not called when the popover is used.
Also deprecated closePicker since it is not
used within the Cordova code. Deprecated in the off chance a plugin
is using - will remove in 2.0.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/becka11y/incubator-cordova-ios
cb819popoverCancel
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-cordova-ios/pull/20.patch
----
commit 8be82b9a339b6629adca735c7d1c0c4fa46702e4
Author: Becky Gibson <[email protected]>
Date: 2012-05-21T14:11:35-07:00
Fixes CB-819 fail callback not invoked
Problem was that on iPad when popover controller is used,
the fail callback was not getting called when the popover was
dismissed w/o picking an image. Added a delay to the callback to JavaScript
since the app will hang if the callback contains a JavaScript alert.
Also removed clause to close popover from imagePickerDidCancel
because that method is not called when the popover is used.
Also deprecated closePicker since it is not
used within the Cordova code. Deprecated in the off chance a plugin
is using - will remove in 2.0.
----
