I reviewed the changes and pulled the latest JS code into my Android project to do some testing. As expected the changes did not affect any of the current Android functionality. So it looks good from my perspective.
One question I wonder about is whether CameraPopoverOptions should only be in iOS as that is the only platform that supports it or whether it should be in all? That way you could move from iOS to other platforms without having to modify you JS code. Simon Mac Donald http://hi.im/simonmacdonald On Fri, May 25, 2012 at 2:30 PM, Becky Gibson <[email protected]> wrote: > The pull request for codova-js didn't come through - although the one for > cordova-ios did post to the list? > > At any rate, since I am changing common code, would appreciate a quick code > review of my changes for camera. Will commit as soon as some gives this a > once over. Note that I added the CameraPopoverOptions object ONLY for iOS. > I think that is appropriate. Although I added the arrowDirections to the > already existing public CameraConstants. > > Associated iOS pull request is out there as well if your interested. > > thanks, > -becky
