I pulled in the patch for Android. I mistakenly close the pull request thinking he only changed the cordova.android.js code and no native Android changes were made.
I think one of the original reasons we were using "eval" on the Android side is that the 1.X versions of Android did not have JSON. Since we've dropped support for 1.X there is no reason to use eval anymore. Simon Mac Donald http://hi.im/simonmacdonald On Sat, Jun 2, 2012 at 2:43 PM, Filip Maj <[email protected]> wrote: > We include json2.js in our BlackBerry implementation because BlackBerry 5 > (which we still support) needs it. iOS should probably follow suit. > > OK, I'll pull in the patch for Android and make the necessary changes for > BlackBerry. > > Thanks all! > > On 6/1/12 6:47 PM, "Patrick Mueller" <[email protected]> wrote: > > >On Fri, Jun 1, 2012 at 9:18 PM, Jesse <[email protected]> wrote: > > > >> I know it is always available, just meant that if it is not built into > >>the > >> browser on a version we support, then we need to add a note that the > >> developer needs to bundle/include it in their html. > >> I believe we still have a comment in the generated html code for iOS for > >> older versions. > > > > > >hmmm. That sounds a bit error-prone. I'm guessing this problem won't be > >with us for too much longer, but I think we should either include json2.js > >on any platform that might not have JSON, or at least provide an > >incredibly > >noisy warning (write into the DOM, alert(), etc), if we detect JSON is not > >available. > > > >-- > >Patrick Mueller > >http://muellerware.org > >
