Test that the script cannot receive params that would make it overwrite itself or any of it's own required files?
On Mon, Jun 4, 2012 at 6:05 PM, Anis KADRI <anis.ka...@gmail.com> wrote: > > https://github.com/imhotep/incubator-cordova-android/blob/master/bin/test_create2.js > > FYI I did not use any testing framework because I don't like dependencies > and this is so simple that I don't think it deserves it. I guess this > one<http://visionmedia.github.com/mocha/>would have been cool. > > Anyhow, take a look and let me know if there is anything else I should be > testing for. > > Summary of what's beeing tested (although quiet obvious in the file itself > ;): > > - project gets created > - project has all the files it needs to compile (main activity, > AndroidManifest.xml, plugins.xml, cordova.xml, ...). > - build project gets cleaned up properly (from common-codecs.jar etc..). > - project compiles > - package file exists > > Anis > > On Thu, May 31, 2012 at 5:02 PM, Dave Johnson <dave.c.john...@gmail.com> > wrote: > > Can we also commit some tests along with this new script? > > > > On Fri, Jun 1, 2012 at 6:59 AM, Joe Bowser <bows...@gmail.com> wrote: > >> I'm starting to think that this shed is mostly paint now. That's what > >> makes it lightweight! > >> > >> On Thu, May 31, 2012 at 1:57 PM, Brian LeRoux <b...@brian.io> wrote: > >> > >>> truth! I forgot they went that way again. (this shed has seen many > >>> coats of paint) > >>> > >>> On Thu, May 31, 2012 at 1:46 PM, Anis KADRI <anis.ka...@gmail.com> > wrote: > >>> > Sure but just to remind you that with the current _create_ it is even > >>> more > >>> > verbose as android's update and create projects are *REALLY* verbose > ;) > >>> > I can definitely add a "-v" flag and make sure that the messages > display > >>> > only if that option is passed. > >>> > > >>> > On Thu, May 31, 2012 at 1:40 PM, Brian LeRoux <b...@brian.io> wrote: > >>> > > >>> >> love everything except the echo stuff; could we add a quiet flag? > only > >>> >> want noise if something breaks > >>> >> > >>> >> On Thu, May 31, 2012 at 12:39 PM, Anis KADRI <anis.ka...@gmail.com> > >>> wrote: > >>> >> > Hi guys, > >>> >> > > >>> >> > I did not want to mess with the current client tools for Android > so I > >>> >> > created a new create script and called it create2. > >>> >> > > >>> >> > The advantages of my script compared to the current one: > >>> >> > - It's only one script. It doesn't use a hidden .cordova directory > and > >>> >> > doesn't use a secondary create script to work. > >>> >> > - It can be run from anywhere in the filesystem and you don't have > to > >>> be > >>> >> in > >>> >> > the repository folder to run it. > >>> >> > - It checks if the android SDK tools are present in the user's > PATH > >>> >> > - It has a usage helper > >>> >> > - It's not too verbose but verbose enough to know when something > goes > >>> >> wrong. > >>> >> > - It doesn't delete a project if it already exists. > >>> >> > - It cleans up after it's done and when it fails. > >>> >> > - It uses some simple templates and doesn't have the sed usage bug > >>> that > >>> >> the > >>> >> > current one has. (ie: it doesn't create an AndroidManifest.xml-e > or > >>> >> > exampleActivity.java-e) > >>> >> > - ... probably more things that I have forgotten. > >>> >> > > >>> >> > It can easily replace the current one but I wanted to get it > reviewed > >>> >> first. > >>> >> > > >>> >> > > >>> >> > >>> > > https://github.com/imhotep/incubator-cordova-android/blob/master/bin/create2 > >>> >> > > >>> >> > If you want to test it out just pull from the repository and run > that > >>> >> > create2 script from anywhere. > >>> >> > > >>> >> > What do you guys think ? > >>> >> > > >>> >> > Anis > >>> >> > > >>> >> > On Thu, May 10, 2012 at 1:00 PM, Filip Maj <f...@adobe.com> wrote: > >>> >> > > >>> >> >> http://incubator.apache.org/cordova/ > >>> >> >> > >>> >> >> > >>> >> >> Click mailing list > >>> >> >> > >>> >> >> Send an email to all *-unsubscribe emails you see. > >>> >> >> > >>> >> >> On 5/10/12 12:51 PM, "Mike Flores" <mikeflores2...@gmail.com> > wrote: > >>> >> >> > >>> >> >> > > >>> >> >> >How can I unsubscribe from all emails from apache?? > >>> >> >> > > >>> >> >> >On 5/10/12 4:49 AM, "Jan Becicka" <jan.beci...@seznam.cz> > wrote: > >>> >> >> > > >>> >> >> >>I'm sorry, I feel stupidÅ > >>> >> >> >>I simply don't see it. I use phonegap 1.7.0 from > phonegap.comand > >>> >> it's > >>> >> >> >>default installation does not create any bin folder. > >>> >> >> >> > >>> >> >> >>I tried to find all "create" files on my disk and it is not > here. > >>> >> >> >>I'm really confused, because I see, that the files are in the > git > >>> >> >> >>repository, but it looks like they are not in phone gap binary > >>> >> >> >>distributionÅ > >>> >> >> >>Thanks, > >>> >> >> >>Jan > >>> >> >> >> > >>> >> >> >> > >>> >> >> >>> yup it does in ./bin, also keep an eye here: > >>> >> >> >>> https://issues.apache.org/jira/browse/CB-630 > >>> >> >> >>> > >>> >> >> >>> > >>> >> >> >>> On Fri, May 4, 2012 at 4:13 AM, Jan Becicka < > >>> jan.beci...@seznam.cz> > >>> >> >> >>>wrote: > >>> >> >> >>> Hm, it looks like iOS does not have such toolsÅ Or did I miss > >>> >> >> >>>something? > >>> >> >> >>> Regards, > >>> >> >> >>> Jan > >>> >> >> >>> > >>> >> >> >>> > >>> >> >> >>>> Every platform has its own set of CLI tools at the moment. > >>> >> >> >>>> > >>> >> >> >>>> See each platform's README file. Android and > BlackBerry-webworks > >>> >> have > >>> >> >> >>>>the > >>> >> >> >>>> ones I am most familiar with. Android has a bash script that > you > >>> >> can > >>> >> >> >>>>use > >>> >> >> >>>> to create projects (./bin/create), and blackberry-webworks > has a > >>> >> >> >>>> cordova-level ant file (for creating projects, a la ant > create > >>> >> >> >>>> -Dproject.path=~/myapp) and a project-level ant file for > >>> deploying, > >>> >> >> >>>> running on simulator, signing, etc. > >>> >> >> >>>> > >>> >> >> >>>> On 4/27/12 4:00 AM, "Patrick Mueller" <pmue...@gmail.com> > >>> wrote: > >>> >> >> >>>> > >>> >> >> >>>> >On Fri, Apr 27, 2012 at 03:58, Jan Becicka < > >>> jan.beci...@seznam.cz > >>> >> > > >>> >> >> >>>>wrote: > >>> >> >> >>>> > > >>> >> >> >>>> >> I'm looking at > >>> >> >> >>>>http://wiki.apache.org/cordova/CommandLineToolingDesign > >>> >> >> >>>> >> and I'd like to ask for help. > >>> >> >> >>>> >> This document describes command line tool "cordova" but > it > >>> looks > >>> >> >> >>>>like > >>> >> >> >>>> >>this > >>> >> >> >>>> >> tool is not distributed with phonegap. Is this tool > already > >>> >> >> >>>>available > >>> >> >> >>>> >> somewhere or is the document just proposal for new > tooling > >>> >> support? > >>> >> >> >>>> >> If this is just a proposal, is it tracked somewhere? > >>> >> >> >>>> >> > >>> >> >> >>>> > > >>> >> >> >>>> >The document you referenced is just some thoughts I wrote > down > >>> >> once > >>> >> >> >>>>when I > >>> >> >> >>>> >had a bit of time to do so. There is no tool, just that > >>> document. > >>> >> >> >>>>The > >>> >> >> >>>> >proposal isn't tracked anywhere yet - I'm not a fan of > >>> >> >> >>>>super-long-lived > >>> >> >> >>>> >bug > >>> >> >> >>>> >reports; I was thinking more than once we settle on a > design, > >>> we > >>> >> can > >>> >> >> >>>>start > >>> >> >> >>>> >writing bugs to implement it. > >>> >> >> >>>> > > >>> >> >> >>>> > > >>> >> >> >>>> >> Or is there any other command line tool for creating > cordova > >>> >> >> >>>>projects? > >>> >> >> >>>> >> > >>> >> >> >>>> > > >>> >> >> >>>> >There are some command-line tools available with some > >>> platforms - > >>> >> I'm > >>> >> >> >>>>not > >>> >> >> >>>> >familiar with them, someone else can chime in on those. > >>> >> >> >>>> > > >>> >> >> >>>> >-- > >>> >> >> >>>> >Patrick Mueller > >>> >> >> >>>> >http://muellerware.org > >>> >> >> > > >>> >> >> > > >>> >> >> > >>> >> >> > >>> >> > >>> > -- @purplecabbage risingj.com