My change has been reverted. The work got tied up in another commit of a bug I was fixing so sorry for pushing the code before getting a chance to talk it over.
Simon Mac Donald http://hi.im/simonmacdonald On Fri, Jun 8, 2012 at 2:31 PM, Simon MacDonald <[email protected]>wrote: > Okay, I'll pull it out. It just means all those folks we told to > change: ctx > > to: ctx.getContext() in 1.5+ > > will now need to make it: ctx.getActivity().getContext() in 1.9+. > > Simon Mac Donald > http://hi.im/simonmacdonald > > > On Fri, Jun 8, 2012 at 2:27 PM, Bryce Curtis <[email protected]>wrote: > >> getContext was not added to interface since it is available from >> getActivity().getContext(). >> >> On Fri, Jun 8, 2012 at 1:24 PM, Simon MacDonald >> <[email protected]> wrote: >> > Yeah, the video player plugin uses it to start playing video. >> > >> > Simon Mac Donald >> > http://hi.im/simonmacdonald >> > >> > >> > On Fri, Jun 8, 2012 at 2:10 PM, Joe Bowser <[email protected]> wrote: >> > >> >> Why would you want to start an activity where you wouldn't get a >> result? >> >> Just to put it on the stack? >> >> >> >> On Fri, Jun 8, 2012 at 11:05 AM, Simon MacDonald >> >> <[email protected]>wrote: >> >> >> >> > Please take a look at: >> >> > >> >> > >> >> > >> >> >> https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-android.git;a=commit;h=95b48705fea2cac0f2561f84d3f1ecf017357b58 >> >> > >> >> > I added getContext and startActivity back into CordovaInterface. Does >> >> > anyone see any problems with this? I've done it to make life with the >> >> > current crop of plugins easier. >> >> > >> >> > Simon Mac Donald >> >> > http://hi.im/simonmacdonald >> >> > >> >> >> > >
