Thanks Jukka! I have made and assigned new issues for all of your points. Will fix these and start a new vote thread when 1.8.0 is ready!
1) https://issues.apache.org/jira/browse/CB-890 https://issues.apache.org/jira/browse/CB-891 https://issues.apache.org/jira/browse/CB-892 2) https://issues.apache.org/jira/browse/CB-893 3) https://issues.apache.org/jira/browse/CB-894 4) https://issues.apache.org/jira/browse/CB-895 https://issues.apache.org/jira/browse/CB-896 https://issues.apache.org/jira/browse/CB-897 https://issues.apache.org/jira/browse/CB-898 5) https://issues.apache.org/jira/browse/CB-899 https://issues.apache.org/jira/browse/CB-900 Cheers, -Steve On Sun, Jun 10, 2012 at 6:12 AM, Jukka Zitting <jukka.zitt...@gmail.com>wrote: > Hi, > > On Wed, Jun 6, 2012 at 1:58 PM, Steven Gill <stevengil...@gmail.com> > wrote: > > Here is the link to Apache Cordova 1.8.0 > http://people.apache.org/~steven/ > > > > Please take a look at let us know if it is ready to be deemed an official > > apache release. > > Looks pretty good! I couldn't spot any major problems. > > Note that the official Cordova release archive would be > cordova-1.8.0-incubating-src.zip, not the top-level cordova-1.8.0.zip > archive. Thus assuming the relevant release vote passes you'd want to > publish the contents of the cordova-1.8.0.zip archive, not the archive > itself, under www.apache.org/dist. As a corollary you can drop the > expanded src/cordova-1.8.0 source tree next to the > cordova-1.8.0-incubating-src.zip archive. > > A few smaller issues you may want to look at: > > 1) The ios folder inside the bin archive is missing a LICENSE file. Do > you want to have a one big bin archive or many smaller ones, one for > each platform? With one big archive it would be useful if there were > aggregate LICENSE/NOTICE files at the top level just like in the src > archive. > > 2) The doc archive is missing LICENSE and NOTICE files. > > 3) Hidden files. The project files are probably (?) there by > intention, but I suppose the .git and .DS_Store ones are not. > > $ find cordova-1.8.0 -name '.*' > ./.DS_Store > ./.git > ./cordova-1.8.0/.DS_Store > ./cordova-1.8.0/src/.DS_Store > > ./cordova-1.8.0/src/cordova-1.8.0/incubator-cordova-android/bin/templates/project/.cordova > > ./cordova-1.8.0/src/cordova-1.8.0/incubator-cordova-android/framework/.classpath > > ./cordova-1.8.0/src/cordova-1.8.0/incubator-cordova-android/framework/.project > ./cordova-1.8.0/src/cordova-1.8.0/incubator-cordova-android/test/.classpath > ./cordova-1.8.0/src/cordova-1.8.0/incubator-cordova-android/test/.project > ./cordova-1.8.0/src/cordova-1.8.0/incubator-cordova-bada/.badaprj > ./cordova-1.8.0/src/cordova-1.8.0/incubator-cordova-bada/.cproject > ./cordova-1.8.0/src/cordova-1.8.0/incubator-cordova-bada/.project > ./cordova-1.8.0/src/cordova-1.8.0/incubator-cordova-bada-wac/.badaprj > ./cordova-1.8.0/src/cordova-1.8.0/incubator-cordova-bada-wac/.project > > ./cordova-1.8.0/src/cordova-1.8.0/incubator-cordova-blackberry-webworks/framework/ext/.classpath > > ./cordova-1.8.0/src/cordova-1.8.0/incubator-cordova-blackberry-webworks/framework/ext/.project > > ./cordova-1.8.0/src/cordova-1.8.0/incubator-cordova-blackberry-webworks/framework/ext/.settings > > 4) I'm not sure if the following source files should have Apache > license headers. Are the auto-generated, contain little or no original > content, come from an external source, or does the format (or relevant > tooling) prevent having a license header? > > > cordova-1.8.0/incubator-cordova-android/bin/templates/project/cordova/create.js > cordova-1.8.0/incubator-cordova-ios/Cordova-based Application/Cordova.plist > > cordova-1.8.0/incubator-cordova-ios/CordovaLib/CordovaLib.xcodeproj/project.pbxproj > cordova-1.8.0/incubator-cordova-webos/Makefile > cordova-1.8.0/incubator-cordova-webos/lib/thumbs.0.5.2.js > cordova-1.8.0/incubator-cordova-wp7/example/CordovaExample.sln > cordova-1.8.0/incubator-cordova-wp7/example/CordovaSourceDictionary.xml > cordova-1.8.0/incubator-cordova-wp7/example/Properties/AssemblyInfo.cs > cordova-1.8.0/incubator-cordova-wp7/example/www/master.css > cordova-1.8.0/incubator-cordova-wp7/framework/WP7CordovaClassLib.sln > cordova-1.8.0/incubator-cordova-wp7/framework/WP7GapClassLibBare.sln > cordova-1.8.0/incubator-cordova-wp7/framework/Properties/AssemblyInfo.cs > cordova-1.8.0/incubator-cordova-wp7/templates/custom/GapSolution.sln > > cordova-1.8.0/incubator-cordova-wp7/templates/custom/Properties/AssemblyInfo.cs > > cordova-1.8.0/incubator-cordova-wp7/templates/custom/Properties/WMAppManifest.xml > cordova-1.8.0/incubator-cordova-wp7/templates/custom/www/master.css > > cordova-1.8.0/incubator-cordova-wp7/templates/full/CordovaSourceDictionary.xml > cordova-1.8.0/incubator-cordova-wp7/templates/full/GapSolution.sln > > cordova-1.8.0/incubator-cordova-wp7/templates/full/Properties/AssemblyInfo.cs > > cordova-1.8.0/incubator-cordova-wp7/templates/full/Properties/WMAppManifest.xml > cordova-1.8.0/incubator-cordova-wp7/templates/full/www/master.css > > cordova-1.8.0/incubator-cordova-wp7/tests/MobileSpecUnitTests/MobileSpecUnitTests.sln > > cordova-1.8.0/incubator-cordova-wp7/tests/MobileSpecUnitTests/Properties/AssemblyInfo.cs > > cordova-1.8.0/incubator-cordova-wp7/tests/MobileSpecUnitTests/Properties/WMAppManifest.xml > > cordova-1.8.0/incubator-cordova-wp7/tests/MobileSpecUnitTests/www/master.css > cordova-1.8.0/incubator-cordova-wp7/tooling/CordovaDeploy/CordovaDeploy.sln > > cordova-1.8.0/incubator-cordova-wp7/tooling/CordovaDeploy/CordovaDeploy/Properties/AssemblyInfo.cs > > 5) Probably a search-replace issue: > > $ grep -r -l com.cordova cordova-1.8.0 > cordova-1.8.0/incubator-cordova-bada/Res/cordova/accelerometer.js > cordova-1.8.0/incubator-cordova-bada/Res/cordova/camera.js > cordova-1.8.0/incubator-cordova-bada/Res/cordova/compass.js > cordova-1.8.0/incubator-cordova-bada/Res/cordova/contact.js > cordova-1.8.0/incubator-cordova-bada/Res/cordova/cordova.js > cordova-1.8.0/incubator-cordova-bada/Res/cordova/debugconsole.js > cordova-1.8.0/incubator-cordova-bada/Res/cordova/geolocation.js > cordova-1.8.0/incubator-cordova-bada/Res/cordova/network.js > cordova-1.8.0/incubator-cordova-bada/Res/cordova/notification.js > cordova-1.8.0/incubator-cordova-bada/src/Accelerometer.cpp > cordova-1.8.0/incubator-cordova-bada/src/Compass.cpp > cordova-1.8.0/incubator-cordova-bada/src/Contacts.cpp > cordova-1.8.0/incubator-cordova-bada/src/DebugConsole.cpp > cordova-1.8.0/incubator-cordova-bada/src/GeoLocation.cpp > cordova-1.8.0/incubator-cordova-bada/src/Kamera.cpp > cordova-1.8.0/incubator-cordova-bada/src/Network.cpp > cordova-1.8.0/incubator-cordova-bada/src/Notification.cpp > cordova-1.8.0/incubator-cordova-bada/src/WebForm.cpp > cordova-1.8.0/incubator-cordova-webos/framework/appinfo.json > > BR, > > Jukka Zitting >
