Because I did not finish running the tests at that moment. I could have deleted all the code; that woulda compiled too ;)
Anyways, passes the tests, I've pushed it up to the main repo. On 6/22/12 10:20 AM, "Joe Bowser" <[email protected]> wrote: >If this fixes compilation, why not push it to master? >On Jun 22, 2012 10:08 AM, "Filip Maj" <[email protected]> wrote: > >> Hye guys, >> >> I pushed a "buttonfix" branch up to apache. All I did was removed what >> looks like unused legacy code from App.java as well as DroidGap.java. >>The >> hardware key binding is now done in cordovawebview. >> >> Additionally, the android JS routes a call to override the back button >>to >> the app plugin, yes, but never actually invokes the "is the back button >> bound" method - so it is unneeded. Therefore I removed it. >> >> I am going through the testing motions now but if someone wants to pull >> down that branch and test from their end too that would be helpful. >> >> On 6/22/12 9:52 AM, "Joe Bowser" <[email protected]> wrote: >> >> >Hey >> > >> >It should be using the webView.bindBackButton in app, and not the >> >other one. I think a merge of the buttons work must have messed up. >> >I'll fix it when I get in the office this morning. >> > >> >Joe >> > >> >On Fri, Jun 22, 2012 at 9:47 AM, Filip Maj <[email protected]> wrote: >> >> 1.8.1 is a branch since cordovawebview was merged into master after >> >>1.8.0. >> >> >> >> Simon I'm looking into the compilation issue. >> >> >> >> On 6/22/12 9:42 AM, "Brian LeRoux" <[email protected]> wrote: >> >> >> >>>also: tags for 1.8.x not on the apache repo >> >>> >> >>>On Fri, Jun 22, 2012 at 11:38 AM, Simon MacDonald >> >>><[email protected]> wrote: >> >>>> Hey all, >> >>>> >> >>>> The recent changes to CordovaInterface where isBackButtonBound has >> >>>> been removed is causing compilation errors. The App class is still >> >>>> trying to call this method. Can someone who's been looking at the >> >>>> changes to button binding on Android look into this ASAP? >> >>>> >> >>>> Simon Mac Donald >> >>>> http://hi.im/simonmacdonald >> >> >> >>
