[ 
https://issues.apache.org/jira/browse/CB-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413176#comment-13413176
 ] 

Aurelien MERCIER commented on CB-765:
-------------------------------------

That's OK, shenanigans happen. I was so excited of getting this fix for 1.9.0, 
imagine my deception when first I learned that my pull request hasn't been 
merged properly and second I'll have to wait couple releases before being able 
to use the upload method.

That's not the end of the world, we're gonna use our own implementation but 
that's not very funny to maintain this code.
Anyway, we'll wait and we will definitely hope to see a great implementation of 
the multiple headers :)
                
> Header support for PhoneGap's FileTransfer (Upload)
> ---------------------------------------------------
>
>                 Key: CB-765
>                 URL: https://issues.apache.org/jira/browse/CB-765
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: iOS
>    Affects Versions: 1.7.0
>            Reporter: Aurelien MERCIER
>            Assignee: Herm Wong
>             Fix For: 1.9.0
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> It would be great to support headers for FileTransfer's iOS version (as done 
> in Android: CB-78).
> Right now, I had redefined CDVFileTranfer for our needs and added just after 
> userAgent definition:
> if(userAgent) {
>               [req setValue: userAgent forHTTPHeaderField:@"User-Agent"];
>       } 
>     
>     NSMutableDictionary* headers = [params objectForKey:@"headers"];
>     NSEnumerator *enumerator = [headers keyEnumerator];
>       id key;
>       id val;
>     NSString *nkey;
>       
>       while (nkey = [enumerator nextObject]) {
>               val = [headers objectForKey:nkey];
>               if(!val || val == [NSNull null]) {
>                       continue;       
>               }
>               // if it responds to stringValue selector (eg NSNumber) get the 
> NSString
>               if ([val respondsToSelector:@selector(stringValue)]) {
>                       val = [val stringValue];
>               }
>               // finally, check whether it is a NSString (for 
> dataUsingEncoding selector below)
>               if (![val isKindOfClass:[NSString class]]) {
>                       continue;
>               }
>         
>         //if ([key respondsToSelector:@selector(stringValue)]) {
>         [req setValue:val forHTTPHeaderField:nkey];
>         //}   
>     }
> If you can include this code or similar one into future version of Cordova it 
> will be awesome.
> Thanks,

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to