Looks alright to me. I think the larger issue is documentation. On 7/25/12 11:51 AM, "Simon MacDonald" <simon.macdon...@gmail.com> wrote:
>If Eclipse was a person I would have killed it today. The >most satisfying thing I could do was quit the app. > >Simon Mac Donald >http://hi.im/simonmacdonald > > >On Wed, Jul 25, 2012 at 2:48 PM, Joe Bowser <bows...@gmail.com> wrote: > >> OK, I re-write the refactor. Tip: Make sure you stash or commit >> something otherwise Eclipse will automagically overwrite it for you. >> >> >> >> On Wed, Jul 25, 2012 at 11:44 AM, Filip Maj <f...@adobe.com> wrote: >> > Update: looks like Eclipse axed Joe's code for this branch. Sad pandas >> all >> > around. >> > >> > On 7/24/12 4:00 PM, "Joe Bowser" <bows...@gmail.com> wrote: >> > >> >>Hey >> >> >> >>Users have started using the CordovaWebView, and they have discovered >> >>that for the majority of Android plugins, that we have to implement >> >>handling of the Android Lifecycle. This is a major downside since >> >>most people don't know how the Android Activity Lifecycle works, since >> >>we've been abstracting that in the DroidGap Activity for years. >> >>Here's the docs for more info on that: >> >> >> >>http://developer.android.com/reference/android/app/Activity.html#Activity >>L >> >>ifecycle >> >> >> >>While we expect that people using this component would be somewhat >> >>comfortable with Android, they shouldn't have to be comfortable with >> >>reading DroidGap.java and copypasting things from it, so I created >> >>utility methods and refactored this into CordovaWebView. Here's my >> >>repo which has the example. >> >> >> >>Does this make sense? I'm changing a very important part of the code >> >>here, and I'd like feedback before putting this in. >> >> >> >>https://github.com/infil00p/callback-android/tree/utility_method >> >> >> >>Joe >> > >>
