Whoops, I meant Wednesday! I still have a Vacation Day tomorrow.
On Mon, Sep 3, 2012 at 9:40 AM, Simon MacDonald <simon.macdon...@gmail.com> wrote: > Okay meng, ping me on Tuesday and we'll see if we can figure out a > solution that fixes both bugs. I knew that code was added for a reason > but couldn't remember/find it. > > Simon Mac Donald > http://hi.im/simonmacdonald > > > On Sun, Sep 2, 2012 at 10:46 PM, Joe Bowser <bows...@gmail.com> wrote: >> Hey >> >> The purpose of putting that back in was to deal with a bug regarding >> the back button and the soft keyboard. If you have a soft keyboard >> open and you press the back button, because the focus isn't on the >> view, the back button no longer works. What we should do is have >> logic to detect whether the WebView has focus or not. >> >> I'll work on it when I'm back in the office on Tuesday. I had to come >> back from the Playa early. :( >> >> Joe >> >> On Tue, Aug 28, 2012 at 9:51 AM, Simon MacDonald >> <simon.macdon...@gmail.com> wrote: >>> Yes, I did not change that behaviour. The root cause of the double >>> menu event was that both the DroidGap.onKeyUp and >>> CordovaWebView.onKeyUp were handling the menu key . >>> >>> Simon Mac Donald >>> http://hi.im/simonmacdonald >>> >>> >>> On Tue, Aug 28, 2012 at 12:46 PM, Filip Maj <f...@adobe.com> wrote: >>>> I believe there was some issue a while back where certain keys could only >>>> be registered with keyUp or something along those lines... >>>> >>>> On 8/28/12 8:59 AM, "Simon MacDonald" <simon.macdon...@gmail.com> wrote: >>>> >>>>>Hey all, >>>>> >>>>>As part of doing regression testing on 2.1.0rc1 I found that the >>>>>menubutton event was being fired twice. In order to fix the bug I >>>>>removed the DroidGap.onKeyUp method from the class. I haven't seen any >>>>>adverse effects of this change but I wanted to float it out there. >>>>>Especially to Joe when he gets back off vacation. >>>>> >>>>>https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-android.git;a= >>>>>commit;h=e07822350ee71f578c15fddfb490f2ebf21b025c >>>>> >>>>>Simon Mac Donald >>>>>http://hi.im/simonmacdonald >>>>
