Sorry a d'oh moment - I tagged it last night. I will do the re-tag.
On Tue, Sep 11, 2012 at 3:56 PM, Shazron <shaz...@gmail.com> wrote: > Let us know of the re-tag so I can re-test etc > > On Tue, Sep 11, 2012 at 3:42 PM, Jesse <purplecabb...@gmail.com> wrote: >> The test should be okay now. I changed the implementation back to >> properly call onError( error object ) >> >> >> >> On Tue, Sep 11, 2012 at 3:39 PM, Filip Maj <f...@adobe.com> wrote: >>> Looks like we need to fix a failing test related to media in cordova-js as >>> well >>> >>> On 9/11/12 2:39 PM, "Jesse MacFadyen" <purplecabb...@gmail.com> wrote: >>> >>>>Have you included my recent commits to cordova-js in your decision making? >>>> >>>>Cheers, >>>> Jesse >>>> >>>>Sent from my iPhone5 >>>> >>>>On 2012-09-11, at 2:35 PM, Joe Bowser <bows...@gmail.com> wrote: >>>> >>>>> +1 to ship >>>>> >>>>> On Tue, Sep 11, 2012 at 2:32 PM, Filip Maj <f...@adobe.com> wrote: >>>>>> Now that android's fixed, +1 to ship. >>>>>> >>>>>> And yeah, moving forward we will do a DISCUSS thread, and tag by the >>>>>>end >>>>>> of that thread. >>>>>> >>>>>> Then move to a VOTE thread to do the.. Well, voting. Yay process! >>>>>> >>>>>> On 9/11/12 10:55 AM, "Herm Wong" <herm.w...@hotmail.com> wrote: >>>>>> >>>>>>> webos tagged 2.1.0 >>>>>>> >>>>>>>> From: simon.macdon...@gmail.com >>>>>>>> Date: Tue, 11 Sep 2012 13:43:36 -0400 >>>>>>>> Subject: Re: [VOTE] 2.1.0 tag and release >>>>>>>> To: callback-dev@incubator.apache.org >>>>>>>> >>>>>>>> Sorry didn't mean to hijack the voting thread. The fix is on so we >>>>>>>>are >>>>>>>> all >>>>>>>> set to go once again on Android. >>>>>>>> >>>>>>>> Simon Mac Donald >>>>>>>> http://hi.im/simonmacdonald >>>>>>>> >>>>>>>> >>>>>>>> On Tue, Sep 11, 2012 at 12:39 PM, Joe Bowser <bows...@gmail.com> >>>>>>>>wrote: >>>>>>>> >>>>>>>>> Can I make my vote a null pointer check? >>>>>>>>> On Sep 11, 2012 9:32 AM, "Mike Reinstein" <reinstein.m...@gmail.com> >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> In that case, I'd like to change my vote from +1 to "mauve". >>>>>>>>>> >>>>>>>>>> -Mike >>>>>>>>>> >>>>>>>>>> On Tue, Sep 11, 2012 at 12:24 PM, Brian LeRoux <b...@brian.io> wrote: >>>>>>>>>> >>>>>>>>>>> FTR, I think this might not be a vote thread. ;) >>>>>>>>>>> >>>>>>>>>>> On Tue, Sep 11, 2012 at 9:04 AM, Joe Bowser <bows...@gmail.com> >>>>>>>> wrote: >>>>>>>>>>>> Bloody Nexus phones and them working properly. It should be >>>>>>>> fine to >>>>>>>>>>>> close if you're doing a null check. >>>>>>>>>>>> >>>>>>>>>>>> On Tue, Sep 11, 2012 at 6:06 AM, Simon MacDonald >>>>>>>>>>>> <simon.macdon...@gmail.com> wrote: >>>>>>>>>>>>> Okay, I opened https://issues.apache.org/jira/browse/CB-1409 >>>>>>>> and I >>>>>>>>>>> pushed >>>>>>>>>>>>> up a fix for it but I need to do some testing on more phones OS >>>>>>>>>> versions >>>>>>>>>>>>> before I close it. >>>>>>>>>>>>> >>>>>>>>>>>>> Simon Mac Donald >>>>>>>>>>>>> http://hi.im/simonmacdonald >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> On Tue, Sep 11, 2012 at 8:09 AM, Simon MacDonald >>>>>>>>>>>>> <simon.macdon...@gmail.com>wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> Actually, Android is not ready to be tagged yet. There is a >>>>>>>> bug >>>>>>>>> when >>>>>>>>>>> you >>>>>>>>>>>>>> click the menu button that will cause a force close of the >>>>>>>> app. I >>>>>>>>> can >>>>>>>>>>>>>> reproduce it in 4.1 emulator but I need to check some other >>>>>>>> phones. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Simon Mac Donald >>>>>>>>>>>>>> http://hi.im/simonmacdonald >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Mon, Sep 10, 2012 at 8:56 PM, Shazron <shaz...@gmail.com> >>>>>>>>> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> cordova-js has been tagged: refs/tags/2.1.0 [created] >>>>>>>> 650e5414e >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Mon, Sep 10, 2012 at 5:54 PM, Shazron <shaz...@gmail.com> >>>>>>>>> wrote: >>>>>>>>>>>>>>>> Tagging now - will inform the list when I am done. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On Mon, Sep 10, 2012 at 5:52 PM, Jesse >>>>>>>> <purplecabb...@gmail.com >>>>>>>>>> >>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>> Shaz, it appears everyone is ready for the JS tag. >>>>>>>>>>>>>>>>> Go ahead and tag cordova-js, and we can all tag our >>>>>>>> platforms >>>>>>>>>>> sometime >>>>>>>>>>>>>>>>> tomorrow after satisfying our individual test criteria. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> On Mon, Sep 10, 2012 at 5:36 PM, Anis KADRI < >>>>>>>>>> anis.ka...@gmail.com> >>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>> Bada and Tizen are ready to be tagged >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> On Mon, Sep 10, 2012 at 5:21 PM, Tim Kim >>>>>>>> <timki...@gmail.com> >>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> BB ready for tagging. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>>> @purplecabbage >>>>>>>>>>>>>>>>> risingj.com >>>>>> >>> >> >> >> >> -- >> @purplecabbage >> risingj.com