Done and done (ran it and committed the changes). There is also a hooks directory in the iOS depot with a pre-commit check that lints your code with uncrustify. If you'd like to use it:
cd .git rm -r hooks ln -s ../hooks . Otherwise, please run the bin/uncrustify.sh command manually before checking in code on iOS. After we try this out for a while, let's collect feedback as to whether we like it or not. On Tue, Sep 18, 2012 at 2:38 PM, Shazron <shaz...@gmail.com> wrote: > More info in this issue: https://issues.apache.org/jira/browse/CB-625 > > On Tue, Sep 18, 2012 at 11:37 AM, Mike Reinstein > <reinstein.m...@gmail.com> wrote: > > Is there a pointer to any info on what uncrustify does? Sorry, I'm new to > > this party. > > > > -Mike > > > > On Tue, Sep 18, 2012 at 2:33 PM, Shazron <shaz...@gmail.com> wrote: > > > >> I'm good with this change (no big changes coming up) > >> > >> On Tue, Sep 18, 2012 at 8:48 AM, Andrew Grieve <agri...@google.com> > wrote: > >> > I've now checked in bin/uncrustify.sh on iOS. > >> > > >> > Running it changes a tonne of files though, so it would be best if > there > >> > were very few outstanding changes to people's local repos when it gets > >> run. > >> > > >> > I still need to merge in the FileTransfer abort & progress events > >> patches, > >> > but then I'll be synced up. Is there anyone else that has changes they > >> want > >> > to merge before this gets run? > >> > > >> > Just a reminder that what we're trying to do here, is use the iOS repo > >> as a > >> > test case to see how well this tool works. We won't be using > uncrustify > >> on > >> > any other repos unless a bunch of time goes by and we're really happy > >> with > >> > it. > >> > > >> > Andrew > >> >
