Are any of these changes the reason I am seeing this this morning: lib/ios/exec.js: line 168, col 30, Use '===' to compare with '0'. lib/scripts/bootstrap.js: line 26, col 9, Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. lib/tizen/plugin/tizen/ContactUtils.js: line 70, col 40, 'initializeAllFieldsMapping' is already defined. lib/webworks/qnx/plugin/qnx/capture.js: line 30, col 9, 'webkitRequestFileSystem' is not defined. lib/webworks/qnx/plugin/qnx/capture.js: line 30, col 33, 'PERSISTENT' is not defined. lib/windows8/plugin/windows8/geolocation.js: line 36, col 13, 'options' is not defined. lib/windows8/plugin/windows8/geolocation.js: line 40, col 40, 'options' is not defined. lib/windows8/plugin/windows8/geolocation.js: line 40, col 60, 'options' is not defined. lib/windows8/plugin/windows8/geolocation.js: line 107, col 9, 'timers' is not defined. lib/windows8/plugin/windows8/geolocation.js: line 107, col 16, 'id' is not defined. lib/windows8/plugin/windows8/geolocation.js: line 107, col 87, 'options' is not defined. lib/windows8/plugin/windows8/geolocation.js: line 107, col 107, 'options' is not defined. lib/windows8/plugin/windows8/geolocation.js: line 108, col 17, 'Geolocation' is not defined. lib/windows8/plugin/windows8/geolocation.js: line 108, col 61, 'options' is not defined. lib/windows8/plugin/windows8/MediaFile.js: line 32, col 44, 'contentType' is not defined.
building commit 56e6476b61ee3e6744a106605be38541bbbe2a2f generated platform: windows8 in 42ms generated platform: blackberry in 20ms generated platform: playbook in 18ms generated platform: qnx in 20ms generated platform: ios in 12ms generated platform: wp7 in 13ms generated platform: android in 13ms generated platform: bada in 15ms generated platform: tizen in 17ms generated platform: errgen in 10ms generated platform: test in 11ms starting node-based tests can't run tests in node: run jake btest instead, or install jsdom via: sudo npm install jsdom On Fri, Oct 5, 2012 at 10:30 AM, Gord Tanner <g...@tinyhippos.com> wrote: > +11 > > I pulled in the simple lint changes since it is a huge win. > > > On Thu, Oct 4, 2012 at 7:01 PM, Filip Maj <f...@adobe.com> wrote: > > Just here to +1 fixing lint errors. Would love to get a patch in to > > eliminate the win8 + tizen JS from warning me about lint errors when I > > build the js :o > > > > On 10/4/12 1:04 PM, "Mark Dineen" <m...@dineen.biz> wrote: > > > >>Hi everyone, > >> > >>I'm working on linting cordova-js. I submitted a pull with the (mostly) > >>obvious ones, but wanted to run the three in this commit by the list > >>before > >>issuing a pull. > >> > >> > https://github.com/mdineen/incubator-cordova-js/commit/198ebe97ba3c38d9bb7 > >>6f94d421812c912c46829 > >> > >>bootstrap - jshint complained that the function CordovaNavigator is > >>declared in a block. I moved it to the top and grepped for other > >>instances, I found no conflicts. > >> > >>Tizen ContactUtils - to me, it appeared that initializeAllFieldsMapping > >>needed to run once and only once, so I changed it to anonymous and > removed > >>the code that clears the local > >> > >>Win8 MediaFile - jshint complained that contentType was undeclared. > >> Grepping around it seemed quite likely that the proper reference for > this > >>should be storageFile.contentType. > >> > >>Please comment on these if you have any concern with my approach. > >> > >>I'm new. My ICLA has been on file since Sep 10, 2012. I'm a contributor > >>to Ripple, working independently on Cordova. > >> > >>Thanks, > >> > >>Mark. > > > > > > -- > Gord Tanner > Senior Developer / Code Poet > tinyHippos Inc. > @tinyhippos >
