+1 to having it as a pre-commit hook that's somewhat enforced. Everything needs an override, but it's still great for these tools to be on by default and to block a commit for (newly introduced) errors.
On Tue, Oct 9, 2012 at 6:14 PM, Patrick Mueller <pmue...@gmail.com> wrote: > Add whatever linter to dependencies in package.json, and call it before > every build, from it's node_modules/.bin script. Isn't it lightning quick, > just spews loads of messages? > > On Tue, Oct 9, 2012 at 5:47 PM, Andrew Grieve <agri...@chromium.org> > wrote: > > > I've been using a pre-commit check on the iOS repo to make sure I don't > > check in crusty code, and I've really liked how this has gone. I get a > > warm-and-fuzzy feeling from having a tool check my code before it gets > > committed. > > > > My vote would be for more of this. E.g. create a hooks/pre-commit file, > and > > change the README.md to tell people to symlink it into their .git > > directory. > > I'd also like to see this enforce change descriptions having [platform] > in > > it, or else even the most diligent of us will eventually forget. > > > > > > On Tue, Oct 9, 2012 at 5:35 PM, Gord Tanner <gtan...@gmail.com> wrote: > > > > > Since we had cleaned up the lint errors last week I have noticed a few > > > more sneak in (including ones I have added :( ). > > > > > > Could we somehow enforce / ensure we have people running the jake > > > command to check lint before commiting / merging? > > > > > > Ideally I would like to keep the number of lint errors to 0 to prevent > > > the massive debt we have incurred so far. > > > > > > > > > -- > Patrick Mueller > http://muellerware.org >
