----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102028/ -----------------------------------------------------------
(Updated July 21, 2011, 9:05 p.m.) Review request for Calligra. Summary ------- Attachd patch makes the probably rather expensive initial parsing and drawing on the QImage operations in the Vectorshape threaded. The thread will only be used to produce the QImage we are using later on to display the vectorshape. Drawing of the QImage itself is not threaded but then that's not an expensive operation like parsing and producing those QImage can be. UPDATE: Seems there is the special case of drawText used in OutputPainterStrategy::extTextOut and SvmPainterBackend::textArray that is not threadsafe under X11 according to http://doc.trolltech.com/4.7/threads-modules.html#painting-in-threads and http://www.qtcentre.org/archive/index.php/t-6542.html . So, the patch next to be extended to use the QPainterPath solution named in the second link. Discarding the review-request therefore. Diffs ----- plugins/vectorshape/VectorShape.h 4229842 plugins/vectorshape/VectorShape.cpp 0a28dac Diff: http://git.reviewboard.kde.org/r/102028/diff Testing ------- Thanks, Sebastian
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
