----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102072/#review5127 -----------------------------------------------------------
libs/flake/KoShapeGroup.cpp <http://git.reviewboard.kde.org/r/102072/#comment4617> If that code is not used anymore, why not remove it? libs/flake/KoShapeManager.cpp <http://git.reviewboard.kde.org/r/102072/#comment4619> The shape might have an empty filter effect stack, which also means no effects. This change also causes a regression. It is no longer possible to have a shadow and filter effects on a shape correctly rendered. libs/flake/KoShapeManager.cpp <http://git.reviewboard.kde.org/r/102072/#comment4620> Seems like something not finished? libs/flake/KoShapeShadow.h <http://git.reviewboard.kde.org/r/102072/#comment4622> Why is this one public, it seems it is only used inside KoShapeShadow? libs/flake/KoShapeShadow.h <http://git.reviewboard.kde.org/r/102072/#comment4624> Extra whitespace, please remove. libs/flake/KoShapeShadow.h <http://git.reviewboard.kde.org/r/102072/#comment4623> Why is this one public, it seems it is only used inside KoShapeShadow? libs/flake/KoShapeShadow.h <http://git.reviewboard.kde.org/r/102072/#comment4625> Extra whitespace, please remove. libs/flake/KoShapeShadow.cpp <http://git.reviewboard.kde.org/r/102072/#comment4621> Looks like debug code, please remove. - Jan On July 24, 2011, 7:11 a.m., Yue Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102072/ > ----------------------------------------------------------- > > (Updated July 24, 2011, 7:11 a.m.) > > > Review request for Calligra. > > > Summary > ------- > > Added support for drawing the shadow for a shape group, fixed shadow blur > zooming bug. > > > Diffs > ----- > > libs/flake/KoShapeGroup.h 5ccd57406ed46bf2dc443bc80df90621011b4a05 > libs/flake/KoShapeGroup.cpp aaa58b4413f7d8bd10d0805c733cd3799052a886 > libs/flake/KoShapeManager.cpp c3b3484ac51070a8e8b17aa75c696a697673fd0d > libs/flake/KoShapeShadow.h 07c760c4cecd3050ecd6af9c4040c2f859242abe > libs/flake/KoShapeShadow.cpp 5485b19109a179845e0b17827025a5c64d378221 > libs/widgets/KoShadowConfigWidget.cpp > 1a410421831aec2e1668bb82c65d652f6c6fdbd1 > plugins/dockers/shadowdocker/ShadowDocker.cpp > ef53fae66ef2f4910eb13726ee9621a4a98c83e3 > > Diff: http://git.reviewboard.kde.org/r/102072/diff > > > Testing > ------- > > http://my.cdash.org/viewTest.php?onlydelta&buildid=212010 > > > Screenshots > ----------- > > groupshadow / shape shadow > http://git.reviewboard.kde.org/r/102072/s/210/ > > > Thanks, > > Yue > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
