> On Jan. 24, 2012, 10:19 a.m., C. Boemann wrote: > > filters/words/html-odf/htmlodfexport.cpp, line 83 > > <http://git.reviewboard.kde.org/r/103778/diff/1/?file=47727#file47727line83> > > > > Maybe we should get this done then.. > > Stuart Dickson wrote: > At present, none of the user configurable options presented in the export > dialog were being filtered through the rest of the process, the TODO is more > a "in future, we may have features we can expose to this". > > The Style options presented to the user only produced an empty styles.css > file, and nowhere in the XML Stylesheet Transformation is a reference to an > external CSS stylesheet set, all the styles are read from the source ODT and > embedded in the html file. > Similarly there did not appear to be any similar links with output > encoding. > > The dialog was removed in order to reduce user confusion/frustration, and > to speed the export process.
The comments in the source code have been updated to reflect this reasoning, whilst keeping the original code handy to allow it to be easily re-enabled in future. - Stuart ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103778/#review10040 ----------------------------------------------------------- On Jan. 24, 2012, 10 a.m., Stuart Dickson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103778/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2012, 10 a.m.) > > > Review request for Calligra. > > > Description > ------- > > Improvements to the html-odf export filter. > > Added support for: exporting images, tables with merged cells. > Modifications to KoFilter derived class to incorporate Conversion class' > convert function and provide improved error checking. > Changes to output styles to improve legibility. > Disabled export filter dialog as it does not have an impact on output, but > can be modified in future. > Removing QChar::ObjectReplacementMarkers from appearing in output. > > The focus has been on the content and not on styles and there is still > improvement in cleaning up the generated output. > > > Diffs > ----- > > filters/words/html-odf/CMakeLists.txt d1bee3f > filters/words/html-odf/ManifestParser.h PRE-CREATION > filters/words/html-odf/ManifestParser.cpp PRE-CREATION > filters/words/html-odf/conversion/converter.xsl 1f01ed6 > filters/words/html-odf/convert.h 8cbdd6c > filters/words/html-odf/convert.cpp 226fbd5 > filters/words/html-odf/htmlodfexport.h bff8dec > filters/words/html-odf/htmlodfexport.cpp 5f0606e > > Diff: http://git.reviewboard.kde.org/r/103778/diff/diff > > > Testing > ------- > > Testing against a couple of sample documents including paragraphs, titles, > simple tables and ones with additional merged cells, inline and paragraph > anchored images. > > > Thanks, > > Stuart Dickson > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
