----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104432/#review11996 -----------------------------------------------------------
Ship it! Great -- it does solve the bug! I wouldn't worry for now about the small issues remaining. When closing, please close bug 294601 as well. - Boudewijn Rempt On March 28, 2012, 1:24 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104432/ > ----------------------------------------------------------- > > (Updated March 28, 2012, 1:24 p.m.) > > > Review request for Calligra and Boudewijn Rempt. > > > Description > ------- > > The algorithm for layouting of the toolbox seems to have a few issues: > * last button with multiple sections on row was cut off at end (spacing > ignored) > * separators could appear on the top side of the toolbox > * and there is the linked bug > > The attached patch is a small cleanup of the code which fixes these issues > for me. Though I am not sure why it fixes the bug actually, might have been > due to the too large rects assigned to the section widgets. > > Still, there is an issue left: > currently it is supported to have a small section to be appended in the last > row of a multi-row section. But this conflicts with that there is normally > some spacing between the rows of different section. So e.g. the separator > between the rows is painted on the bottom of the buttons of the row before. > This is both with this patch and master. What to do about that? Not allow > appending to multi-row sections? Have spacing also between rows of multi-row > section? Do not do row separators between sections? > > > This addresses bug 294601. > http://bugs.kde.org/show_bug.cgi?id=294601 > > > Diffs > ----- > > libs/main/KoToolBox.cpp eb8c17f > libs/main/KoToolBoxLayout_p.h fcfac47 > libs/main/KoToolBox_p.h 628aacc > > Diff: http://git.reviewboard.kde.org/r/104432/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
