> On April 5, 2012, 1:06 a.m., Marijn Kruisselbrink wrote: > > One thing I'd really like to have before this goes in is unit tests. > > Currently (almost?) every function has several unit tests to test for > > correctness, so I don't really want new functions that get added to not > > have at least some basic unit tests.
Ok. I'll write unit tests for the formulas. - Nityam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104487/#review12176 ----------------------------------------------------------- On April 5, 2012, 12:56 a.m., Nityam Vakil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104487/ > ----------------------------------------------------------- > > (Updated April 5, 2012, 12:56 a.m.) > > > Review request for Calligra. > > > Description > ------- > > To fully support all of the defined heighest level 4 formulas, I added > support for formulas averageif, averageifs, sumifs, countifs. > > > Diffs > ----- > > sheets/ValueCalc.h d0018c2 > sheets/ValueCalc.cpp 7e6f3a3 > sheets/functions/math.cpp d57ce94 > sheets/functions/statistical.cpp 020b03e > > Diff: http://git.reviewboard.kde.org/r/104487/diff/ > > > Testing > ------- > > I've tested above formulas with some test data attached here. And it seems to > be working fine. > > > Thanks, > > Nityam Vakil > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
