-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104666/
-----------------------------------------------------------

Review request for Calligra.


Description
-------

Currently in all programs (besides Words) the tab chooser is wrongly displayed 
somewhere on the horizontal ruler. And also if not needed, i.e. tabs are no 
property of the shape.

Attached patch fixes that:
* it puts the tab chooser in the corner for Stage and Karbon (so not for Krita, 
because less text oriented)
* it only creates the tab chooser on demand, not always (so it does not appear 
for Krita, like now)
* it only shows the tabs chooser if tabs are also shown in the ruler

Candidate for 2.4 backport?


Diffs
-----

  karbon/ui/KarbonView.cpp 2b9a907 
  libs/kopageapp/KoPAView.cpp fc28628 
  libs/main/KoRuler.cpp 4272b9b 
  libs/main/KoRuler_p.h bfeac46 

Diff: http://git.reviewboard.kde.org/r/104666/diff/


Testing
-------

Started Krita, Karbon, Stage, Words and activated text shapes, had rulers shown 
and not shown.


Thanks,

Friedrich W. H. Kossebau

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Reply via email to