> On May 13, 2012, 7:14 p.m., Inge Wallin wrote: > > In general I must say that I like this. I have worked with it a little and > > I like the feeling. I also like the fact that the scrollbars are not > > present when they don't need to be. > > > > The only issue I found while working with it is that if I move a shape to > > the slide's border so that it's halfway outside and halfway inside, then > > the slide border is shown through it (or the border is painted on top of > > it). I think this is a really minor issue but if it's easy to fix then I > > guess it should be. > > > > I had some code issues as well, but also minor ones. Maybe the naming issue > > I point out below should be rethought.
Fixed the page margins being painted on top of the shapes > On May 13, 2012, 7:14 p.m., Inge Wallin wrote: > > libs/kopageapp/KoPACanvas.cpp, line 47 > > <http://git.reviewboard.kde.org/r/104928/diff/1/?file=64123#file64123line47> > > > > This is totally obscure to me. I think there should be a comment to > > explain what's happening. i just removed the line - C. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104928/#review13786 ----------------------------------------------------------- On May 14, 2012, 11:42 p.m., C. Boemann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104928/ > ----------------------------------------------------------- > > (Updated May 14, 2012, 11:42 p.m.) > > > Review request for Calligra. > > > Description > ------- > > KoPageApp applications Stage and Flow used to have extra space reserved > around the page/slide so objects could be put there. However that made it > really hard for the user to work with. > > This patch changes that so there si no space around the page/slide. But.. > instead you can drag objects outside the page/slide without any limit at all > > > Diffs > ----- > > libs/kopageapp/KoPACanvas.cpp 4a4748c > libs/kopageapp/KoPAView.h 01fbdf1 > libs/kopageapp/KoPAView.cpp 4d13dfa > libs/kopageapp/KoPAViewModeNormal.cpp d5aa5f6 > libs/widgets/KoZoomController.h 4f4c6a2 > libs/widgets/KoZoomController.cpp e10c5b4 > stage/part/KPrViewModeNotes.h b707770 > stage/part/KPrViewModeNotes.cpp c951ade > > Diff: http://git.reviewboard.kde.org/r/104928/diff/ > > > Testing > ------- > > I've tested zooming in and out in Stage normal, notes, and sorter viewmodes, > and in Flow. > > I've tested that running presentations still work, however I've not tested > presenterview. > > I've tested moving shapes outside the page/slide in both Stage and Flow. > > > Thanks, > > C. Boemann > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
