----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105164/#review14455 -----------------------------------------------------------
Please look at my suggestions first. Thank you very much for reviewing the messages - we missed such attention to details! - Jarosław Staniek On June 6, 2012, 4:37 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105164/ > ----------------------------------------------------------- > > (Updated June 6, 2012, 4:37 p.m.) > > > Review request for Calligra and Adam Pigg. > > > Description > ------- > > See summary. In detail the patch does: > * use "Export" instead of "Save" everywhere > * give hint to used file formats in tooltip/whatsthis > * use same phrases with all formats > > Like that solution? > > I was also tempted to turn the export buttons into a dropdown menu, to make > the toolbar less cluttered. No idea if that would clash with any Kexi UI > guidelines... > > > Diffs > ----- > > kexi/doc/dev/CHANGELOG-Kexi-js f4c055c > kexi/plugins/reports/kexireportview.h d119a86 > kexi/plugins/reports/kexireportview.cpp 0482984 > > Diff: http://git.reviewboard.kde.org/r/105164/diff/ > > > Testing > ------- > > Exported to all three formats, incl. overwriting files or not. > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
