Am Freitag, 8. Juni 2012, 05:23:16 schrieb Thorsten Zachmann:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105180/#review14507
> -----------------------------------------------------------
>
> Ship it!
>
>
> Please commit after fixing the details I noticied. If I miss someting on the
> inline stuff lets discuss it before committing.
>
> One thing I noticed which is not due to your code but only visible when your
> code is there is that if you enter the first/last page in the widget the
> actions do not get enabled/disabled and therefore it shows the old state of
> the actions, e.g. when entering the last page the next and last action
> should be disabled and the first/previous should be enabled.
Found at least a workaround, or perhaps even the right-thing-to-do here,
setting the active page via the proxyobject, like KoPAView::navigatePage(...)
does.
Okay to commit?
Cheers
Friedrich
diff --git a/libs/kopageapp/widgets/KoPageNavigator.cpp b/libs/kopageapp/widgets/KoPageNavigator.cpp
index 09d38c0..2ecdc9a 100644
--- a/libs/kopageapp/widgets/KoPageNavigator.cpp
+++ b/libs/kopageapp/widgets/KoPageNavigator.cpp
@@ -208,7 +208,7 @@ void KoPageNavigator::onPageNumberEntered()
KoPAPageBase* newPage = pages.value(pageNumber-1);
if (newPage) {
- d->view->setActivePage(newPage);
+ d->view->proxyObject->updateActivePage(newPage);
}
d->view->setFocus();
}
_______________________________________________
calligra-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/calligra-devel
