----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105182/#review14542 -----------------------------------------------------------
Ship it! Ship It! - Adam Pigg On June 9, 2012, 9:35 a.m., Jarosław Staniek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105182/ > ----------------------------------------------------------- > > (Updated June 9, 2012, 9:35 a.m.) > > > Review request for Calligra, Adam Pigg, Dimitrios Tanis, and Oleg Kukharchuk. > > > Description > ------- > > Set limit to 255 for Text type in MySQL Driver > > MySQL Driver: > *set limit to 255 for Text type (VARCHAR) > *call "SET SESSION sql_mode='TRADITIONAL'" on opening database - needed to > turn warnings about trimming string values into SQL errors > > > This addresses bug 301136. > http://bugs.kde.org/show_bug.cgi?id=301136 > > > Diffs > ----- > > kexi/doc/dev/CHANGELOG-Kexi-js 18e47c81f96b4382468369c59437dec54d573aa4 > kexi/kexidb/connection.cpp 6ffabc64364a46a65aa65e2a29a4e2d657c51445 > kexi/kexidb/driver.cpp 8b527c7c952e3b40546c10c52fc0a04dcf464341 > kexi/kexidb/driver_p.h b6d4af33f8a8279b5bdae1b1683770b91083ad98 > kexi/kexidb/drivers/mySQL/mysqlconnection_p.cpp > 7c4ea06c053fb77fbb7ba808564a1d9f24b6e4b8 > kexi/kexidb/drivers/mySQL/mysqldriver.cpp > 82edd6a678f27ce7b00bc90456ab5cb75b4e7683 > > Diff: http://git.reviewboard.kde.org/r/105182/diff/ > > > Testing > ------- > > Tested with MySQL 5.5. Works because this commit reverts the behaviour of > connection to previous state in case of MySQL. > > > Thanks, > > Jarosław Staniek > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
