> On June 12, 2012, 10:14 a.m., C. Boemann wrote: > > Uhm how does this play in to the KoPrintDialog. > > > > I'm not trying to prevent your usecase, but on the other hand I don't think > > we should make our API even more complicated, than it unfortunately already > > is. so I just want to be sure we have though this through. > > Dag Andersen wrote: > The exact problem I have now (sheets too) is that number of pages can > change dependent on settings in the print dialog like orientation, paper size > etc which triggers the need to update this in the dialog. > The basic problem here is that the print system is designed for wysiwyg > apps and does not cater well for the rest of us. > I could not find an less intrusive solution but I am open to suggestions. > > C. Boemann wrote: > yes I understand your problem, and we should solve it. I just wonder if > we could maybe change what we have. Building more broken api on top of an > already broken api seems like the wrong way forward. I'm just asking here. It > may be you solution is the best, but it doesn't seem like a clear decision to > me
Only alternative I have been able to think of without a hook into the app (like via KoView) is to implement a more flexible print dialog than QPrintDialog which can be "customized" via KoPrintJob (so the app hook is via KoPrintJob instead). E.g. KoPrintJob::createOptionWidgets() could be enhanced with more complex stuff. I could solve plans current problem if the QPrinterDialog was passed to createOptionWidgets(), but it would not be as flexible as a method in KoView, of course. - Dag ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105225/#review14647 ----------------------------------------------------------- On June 12, 2012, 8:35 a.m., Dag Andersen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105225/ > ----------------------------------------------------------- > > (Updated June 12, 2012, 8:35 a.m.) > > > Review request for Calligra. > > > Description > ------- > > View centric apps (plan, sheets) need better control of the print dialog than > what is possible today. > This patch moves the creation of QPrintDialog into a virtual method in KoView > to enable apps to access it or create their own dialog. > > > Diffs > ----- > > libs/main/KoMainWindow.cpp 6720a95 > libs/main/KoView.h ba46c02 > libs/main/KoView.cpp af3aba8 > > Diff: http://git.reviewboard.kde.org/r/105225/diff/ > > > Testing > ------- > > Printing still works with words > > > Thanks, > > Dag Andersen > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
