> On June 15, 2012, 2:16 a.m., Thorsten Zachmann wrote: > > Looks good. Thanks for your efforts. > > > > But there are some things I am not decided about: > > * should the wheel events also be dealt with if the mouse hovers the > > buttons? > > > > I think that would be a nice addition. > > > > * proper behavior in Right-to-left environment is? > > > > For the wheel I think there is no difference. The document is read from top > > to bottom. > > > > * what to do if the page editor has focus? > > a) ignore wheel event > > b) exit edit mode (dropping any changes), then scroll as in display mode > > c) take current edited number, exit edit mode, select page, then scroll > > as in display mode > > d) change the edited number and stay in edit mode, but do not activate a > > page > > e) change the edited number and stay in edit mode, activate the page with > > the number > > > > Implemented is currently b), because it felt to me better and more > > consistent. > > Currently only on pressing Enter an edited number is picked up, set > > respective page selected and the editor left. > > Why would one start enter a new number and then switch to use the mouse > > wheel? Switching to the wheel is more like > > cancelling the editing mode, not continuing. > > > > I think b is good. > >
Thanks for review. Buttons are now also watched for wheel events, no special handling of RTL, b) is kept. Happily committed in time for 2.5 :) - Friedrich W. H. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105229/#review14753 ----------------------------------------------------------- On June 14, 2012, 4:12 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105229/ > ----------------------------------------------------------- > > (Updated June 14, 2012, 4:12 p.m.) > > > Review request for Calligra, Yue Liu and Thorsten Zachmann. > > > Description > ------- > > I found that I sometimes would like to scroll the pages with the status bar > page navigator. > So this patch adds support for switching the pages with wheel events. > It makes the page navigator behave similar to a vertical scroll bar (so not > like a normal integer editor), > as it seems similar in the UI concept to me: > * control buttons on the left and right (not up/down) > * page number like a representative/symbol of the current page, and pages are > ordered with lower page numbers first > This way it feels more natural to me (had it first differently). > > But there are some things I am not decided about: > * should the wheel events also be dealt with if the mouse hovers the buttons? > * proper behavior in Right-to-left environment is? > * what to do if the page editor has focus? > a) ignore wheel event > b) exit edit mode (dropping any changes), then scroll as in display mode > c) take current edited number, exit edit mode, select page, then scroll as > in display mode > d) change the edited number and stay in edit mode, but do not activate a > page > e) change the edited number and stay in edit mode, activate the page with > the number > > Implemented is currently b), because it felt to me better and more consistent. > Currently only on pressing Enter an edited number is picked up, set > respective page selected and the editor left. > Why would one start enter a new number and then switch to use the mouse > wheel? Switching to the wheel is more like > cancelling the editing mode, not continuing. > > What is your opinion? > > > Diffs > ----- > > libs/kopageapp/widgets/KoPageNavigator.cpp 2ecdc9a > libs/kopageapp/widgets/KoPageNavigatorButton_p.h f7fdc26 > > Diff: http://git.reviewboard.kde.org/r/105229/diff/ > > > Testing > ------- > > Scrolled with a few slides, with and without page number editing mode. > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
