----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105618/#review16116 -----------------------------------------------------------
This review has been submitted with commit d422b5e7331a4a592a68af06e151ad198fff4664 by Sven Langkamp to branch master. - Commit Hook On July 19, 2012, 12:16 p.m., Michael O'Sullivan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105618/ > ----------------------------------------------------------- > > (Updated July 19, 2012, 12:16 p.m.) > > > Review request for Calligra. > > > Description > ------- > > This patch addresses Bug 299844: In Krita using a shape tool creates new > vector/shape layer even if a vector layer is selected. > > The bug was caused by calls to KisSystemLocker for the current node that > meant the activeLayer failed its isEditable test, and instead a new layer was > created for the shape. The bug affected the rectangle, ellipse, polyline, and > polygon tools. The polyline tool worked correctly however. Changes were made > to the above tools so that they were consistent with the invocation of > KisSystemLocker in the kis_tool_path.cc implementation. > > This bug would be prominent in attempts to follow the workflow showcased in > the Comics with Krita DVD. > > Many thanks to Sven Langkamp for much patient guidance. > > > This addresses bug 299844. > http://bugs.kde.org/show_bug.cgi?id=299844 > > > Diffs > ----- > > krita/plugins/tools/defaulttools/kis_tool_ellipse.cc 64af967 > krita/plugins/tools/defaulttools/kis_tool_rectangle.cc 9d6997e > krita/plugins/tools/selectiontools/kis_tool_select_elliptical.cc e52bb5d > krita/plugins/tools/selectiontools/kis_tool_select_polygonal.cc 1f91265 > krita/plugins/tools/tool_polygon/kis_tool_polygon.cc e5edd5e > krita/plugins/tools/tool_polyline/kis_tool_polyline.cc feeeb57 > krita/ui/tool/kis_tool_ellipse_base.cpp 4384850 > krita/ui/tool/kis_tool_polyline_base.cpp 053fe6e > > Diff: http://git.reviewboard.kde.org/r/105618/diff/ > > > Testing > ------- > > The tools have been used to paint in both vector and paint layers, with > copying and resizing, and seem to work as expected. > > > Thanks, > > Michael O'Sullivan > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
