----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105623/#review16167 -----------------------------------------------------------
This review has been submitted with commit 0d915df5a16a0d34b007a98431a7c1a17af3d88c by Gopalakrishna Bhat A to branch master. - Commit Hook On July 20, 2012, 4:09 p.m., Gopalakrishna Bhat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105623/ > ----------------------------------------------------------- > > (Updated July 20, 2012, 4:09 p.m.) > > > Review request for Calligra. > > > Description > ------- > > Currently while exporting PDF we do not check if we are able to create the > file at the location or not. This leads to the "Export to PDF" action to fail > silently. This patch adds check for that and the user is notified of failure. > > Though I could not test in the exact environment as mentioned in bug 291925, > what I did was that I created a folder with no write permissions and tried to > export PDF to that folder. In my test environment I could see that export > failed silently without this patch. > > > This addresses bug 291925. > http://bugs.kde.org/show_bug.cgi?id=291925 > > > Diffs > ----- > > libs/main/KoMainWindow.cpp 98538a8 > libs/main/KoPrintJob.h c4fe023 > libs/main/KoPrintJob.cpp ff51adb > > Diff: http://git.reviewboard.kde.org/r/105623/diff/ > > > Testing > ------- > > Tested with Words, Stage, Sheets, Plan, Flow and Krita. > > > Thanks, > > Gopalakrishna Bhat > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
