----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107580/#review22980 -----------------------------------------------------------
Ship it! While the patch itself looks fine I would be much more comfortable with an exported class that didn't have implementations in the .h file. That's the opposite of binary forward compatibility. But for now and to reduce the warnings, it's fine. - Inge Wallin On Dec. 4, 2012, 2:47 p.m., Philip Hoof wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107580/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2012, 2:47 p.m.) > > > Review request for Calligra and Boudewijn Rempt. > > > Description > ------- > > This patch makes Global.h of sheets/ stop using old-style casts, avoiding a > compiler warning for projects using Calligra's sheets component. > > > Diffs > ----- > > sheets/Global.h 1759095 > > Diff: http://git.reviewboard.kde.org/r/107580/diff/ > > > Testing > ------- > > > Thanks, > > Philip Hoof > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
