----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108066/ -----------------------------------------------------------
Review request for Calligra and Marijn Kruisselbrink. Description ------- A few dialogs in Sheets have the general buttons on the right side, not the bottom like these days almost all (KDE) dialogs have. I would propose to have change those few dialogs to have the buttons at the bottom as well, even if the dialog then uses more space as needed in that compact form. Attached patch fixes that for the CSV export dialog and the Conditional Styles dialog, as that is a simple one-line removal. The other two places, Named Area dialog and Style Manager dialog, would need some more work, so I first wait for the okay before I post a patch for review here for those as well. So okay to commit the attached patch and start work to change the two other dialogs as well? Any other place known with buttons at the right side instead of the bottom (might be no KDialog-derived ones)? Diffs ----- filters/sheets/csv/csvexportdialog.cpp d2fd2fc sheets/dialogs/ConditionalDialog.cpp f5b1e26 Diff: http://git.reviewboard.kde.org/r/108066/diff/ Testing ------- Thanks, Friedrich W. H. Kossebau
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
