----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108861/#review26999 -----------------------------------------------------------
Ship it! I agree with boemann, it looks sane and if you have done some good testing everything should be ok. Just note that for the full solution for tables you need to look at the FIXME below. filters/words/epub/OdtHtmlConverter.cpp <http://git.reviewboard.kde.org/r/108861/#comment20357> If you want to make full support for tables, you need to implement this FIXME as well. - Inge Wallin On Feb. 8, 2013, 4:34 p.m., Arjen Hiemstra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108861/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2013, 4:34 p.m.) > > > Review request for Calligra. > > > Description > ------- > > This changes the HTML filter to more properly handle ODF tables. It now > handles <table:table-header-rows> and <table:table-rows> elements, styling is > applied properly and rowspan is supported. > > Probably the biggest behavioural change is that style names are now filtered > for illegal characters, currently specifically "." which was used in the > table styles. > > > Diffs > ----- > > filters/words/epub/OdtHtmlConverter.h dd753aa > filters/words/epub/OdtHtmlConverter.cpp 6564cd3 > > Diff: http://git.reviewboard.kde.org/r/108861/diff/ > > > Testing > ------- > > Exported both a simple table with no headers and a more complex table with > headers. Both now look much more like what it looks like in Words. > > > Thanks, > > Arjen Hiemstra > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
