----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109108/#review28038 -----------------------------------------------------------
Ship it! +1 for this, and backport to 2.6 I will reply to the thread on the ML in a couple of days, just returned back from a very tiring event and overloaded. - Shantanu Tushar On Feb. 22, 2013, 11:42 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109108/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2013, 11:42 p.m.) > > > Review request for Calligra and Shantanu Tushar. > > > Description > ------- > > Follow-up to http://git.reviewboard.kde.org/r/108996 > > Inside CalligraActive code the mimetypes are hardcoded a second time, in the > overloads of CAAbstractDocumentHandler::supportedMimetypes(). > This seems needed, because Calligra Active as a single app supports three > kinds of documents, so first has to check by the mimetypes which of the three > document kind handler has to be used. > > Attached patch is a workaround for the principal problem, syncs the list of > mimetypes in the handler with those in calligraactive.desktop . > > See also email "Problems with Calligra Active and mimetypes" to mailinglist > calligra-devel. > > Okay to backport to 2.6? > > > Diffs > ----- > > active/src/CAPresentationHandler.cpp 319c60f > active/src/CASpreadsheetHandler.cpp 62670e8 > active/src/CATextDocumentHandler.cpp 5f4db02 > > Diff: http://git.reviewboard.kde.org/r/109108/diff/ > > > Testing > ------- > > Applied patch for package for Plasma Active, loads a lot more files now > > (already merged into main repo, see > https://build.pub.meego.com/package/files?package=calligra&project=Project%3AKDE%3ADevel > ) > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
