> On June 10, 2013, 12:30 p.m., C. Boemann wrote: > > I think this is wrong. We shouldn't save position unless asked to (by > > setting the OdfPosition flag) > > > > I'm not even sure why not saving 0,0 is wrong? But the way you solve it > > looks wrong to me. > > Inge Wallin wrote: > That's right, of course. I solved the problem but I introduced a new > one; good catch. Not saving 0,0 is a problem when it is asked to save the > position either by adding OdfPosition or OdfTransformation to the flags, not > if neither is given.
Should this be discarded then? - Thorsten ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110928/#review34042 ----------------------------------------------------------- On June 10, 2013, 8:13 a.m., Inge Wallin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110928/ > ----------------------------------------------------------- > > (Updated June 10, 2013, 8:13 a.m.) > > > Review request for Calligra. > > > Description > ------- > > When a shape is in the position 0, 0 and there are no other transformations, > the position will not be saved back. In other words, there will be an > svg:height and svg:width but no svg:x or svg:y. I noticed this while trying > to fix https://bugs.kde.org/show_bug.cgi?id=184727. > > This patch fixes this bug. I suggest that we apply it to 2.7 as well and > maybe also to 2.6. > > > Diffs > ----- > > libs/flake/KoShape.cpp 6d14a8c > > Diff: http://git.reviewboard.kde.org/r/110928/diff/ > > > Testing > ------- > > Tested with the file mentioned above. > > > Thanks, > > Inge Wallin > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
