> On June 11, 2013, 6:47 a.m., C. Boemann wrote: > > I think "Page Outline" would be a better name then (you should be able to > > change that by replacing in the diff file and applying the diff to a clean > > tree)
As we discussed on IRC, I agree with boemann here. Page outline is even better. What's happening here? I think it's time to commit and push. - Inge ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110949/#review34104 ----------------------------------------------------------- On June 11, 2013, 5:24 a.m., Jigar Raisinghani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110949/ > ----------------------------------------------------------- > > (Updated June 11, 2013, 5:24 a.m.) > > > Review request for Calligra, Inge Wallin and Marijn Kruisselbrink. > > > Description > ------- > > Currently, Calligra Sheets has a feature called Page Borders which displays > the boundaries for pages. This is useful to get an idea of where a page ends > and new page begins. But these are NOT actual Borders/Boundaries but just the > Markers. Page Borders would mean ACTUAL Borders(customizable) and not just > markers. So, Renaming "Page Borders" to "Page Markers" > > > Diffs > ----- > > filters/sheets/excel/import/ExcelImport.cpp 53decbd > filters/sheets/excel/import/excelimporttoods.cc 6f6c574 > filters/sheets/libkspreadexport/KSpreadLeader.cc 9880b11 > sheets/ApplicationSettings.h c3828f2 > sheets/ApplicationSettings.cpp c779129 > sheets/Sheet.h 7090a8c > sheets/Sheet.cpp 7d3548a > sheets/commands/PageBreakCommand.cpp 7f0f49a > sheets/commands/SheetCommands.h 68a30e1 > sheets/commands/SheetCommands.cpp b501c06 > sheets/functions/TODO/settings.xml f2fd91a > sheets/interfaces/SheetAdaptor.h cf0ec69 > sheets/interfaces/SheetAdaptor.cpp c4a51ce > sheets/part/View.h 4be69c4 > sheets/part/View.cpp 131e645 > sheets/part/dialogs/InterfaceOptionsWidget.ui 0afc27c > sheets/part/dialogs/PreferenceDialog.cpp 721ce25 > sheets/part/dialogs/SheetPropertiesDialog.h 2330ae6 > sheets/part/dialogs/SheetPropertiesDialog.cpp 858fdb3 > sheets/part/dialogs/SheetPropertiesWidget.ui 1d41fc7 > sheets/sheets.kcfg c0ec520 > sheets/sheets.rc 6256df6 > sheets/sheets_readonly.rc 1e9e248 > sheets/ui/CellView.cpp d2b6e26 > > Diff: http://git.reviewboard.kde.org/r/110949/diff/ > > > Testing > ------- > > Yes, Page Borders renamed to Page Markers successfully. > > > Thanks, > > Jigar Raisinghani > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
