----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111265/#review35165 -----------------------------------------------------------
Ship it! built it and did a short test, it seems to work fine! - Boudewijn Rempt On June 26, 2013, 10:55 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111265/ > ----------------------------------------------------------- > > (Updated June 26, 2013, 10:55 p.m.) > > > Review request for Calligra. > > > Description > ------- > > After the renaming of the filters modules here now the renaming of all > plugins which are not yet namespaced. > > For the naming pattern the service type of the plugin was copied: > Calligra/Dock -> calligra_docker_ > Calligra/Tool -> calligra_tool_ > Calligra/Shape -> calligra_shape_ > etc. > > The Braindump specific plugins are prefixed with "braindump_" instead of > "calligra_", following how all other app-specific plugins are also namespaced > with the app name as prefix, more or less. > > About the touched helper libs: > I also renamed the lib "chartshapelib" to "calligrachartshape", the suffix > lib resulted in the strange name "libchartshapelib". Not sure that lib is > really needed, could be perhaps just be a static lib, because besides the > tests only the plugin uses it. But different problem, so for a different > patch. > Similar with "kformulalib", renamed to "kformula". > > > Diffs > ----- > > braindump/plugins/stateshape/CMakeLists.txt c2376de > braindump/plugins/stateshape/stateshape.desktop d089fc9 > braindump/plugins/webshape/CMakeLists.txt 8630ce5 > braindump/plugins/webshape/webshape.desktop b043153 > libs/basicflakes/plugin/CMakeLists.txt ab06433 > libs/basicflakes/plugin/basicflakesplugin.desktop 0f2dad1 > plugins/artistictextshape/CMakeLists.txt c1c0bcb > plugins/artistictextshape/artistictextshape.desktop 2f67422 > plugins/chartshape/CMakeLists.txt 5517448 > plugins/chartshape/chartshape.desktop 6969873 > plugins/chartshape/tests/CMakeLists.txt e415974 > plugins/chartshape/tests/odf/bubble-chart/CMakeLists.txt ff477c0 > plugins/chartshape/tests/odf/bug239802/CMakeLists.txt 7440077 > plugins/chartshape/tests/odf/default-calligra-chart/CMakeLists.txt 61d19b1 > plugins/chartshape/tests/odf/default-ooo-chart/CMakeLists.txt d522075 > > plugins/chartshape/tests/odf/me07_percentage_stacked_bar_chart/CMakeLists.txt > 0620919 > plugins/chartshape/tests/odf/template/CMakeLists.txt fb163ad > plugins/commentshape/CMakeLists.txt e4c130f > plugins/commentshape/commentshape.desktop 76081d8 > plugins/defaultTools/CMakeLists.txt 1f16010 > plugins/defaultTools/defaulttools.desktop b4259e3 > plugins/dockers/CMakeLists.txt dde9e22 > plugins/dockers/calligradockers.desktop 635ba49 > plugins/formulashape/CMakeLists.txt 718f3c6 > plugins/formulashape/formulashape.desktop 29a66b4 > plugins/formulashape/tests/CMakeLists.txt c411463 > plugins/musicshape/CMakeLists.txt c44baea > plugins/musicshape/musicshape.desktop 8023797 > plugins/pathshapes/CMakeLists.txt 96fb22b > plugins/pathshapes/pathshapes.desktop 2f6148e > plugins/pictureshape/CMakeLists.txt ea2890a > plugins/pictureshape/pictureshape.desktop 2f5212e > plugins/pluginshape/CMakeLists.txt a95ed0c > plugins/pluginshape/pluginshape.desktop 896c404 > plugins/spacenavigator/CMakeLists.txt 3c56f64 > plugins/spacenavigator/spacenavigator.desktop cf58384 > plugins/staging/templateshape/CMakeLists.txt 7a0b40a > plugins/staging/templateshape/templateshape.desktop 21d4a0d > plugins/staging/threedshape/CMakeLists.txt e50f4c6 > plugins/staging/threedshape/threedshape.desktop 4a9bf44 > plugins/textediting/autocorrection/CMakeLists.txt 56e6b53 > plugins/textediting/autocorrection/autocorrect.desktop cb26717 > plugins/textediting/changecase/CMakeLists.txt 08e2666 > plugins/textediting/changecase/changecase.desktop 49678ac > plugins/textediting/spellcheck/CMakeLists.txt f349f3a > plugins/textediting/spellcheck/spellcheck.desktop 408b670 > plugins/textediting/thesaurus/CMakeLists.txt 8cad11e > plugins/textediting/thesaurus/thesaurustool.desktop bc568c8 > plugins/textshape/CMakeLists.txt 3bc3628 > plugins/textshape/textshape.desktop 5163b71 > plugins/variables/CMakeLists.txt 2296b01 > plugins/variables/textvariables.desktop 826e335 > plugins/vectorshape/CMakeLists.txt 8aa997c > plugins/vectorshape/vectorshape.desktop d847227 > plugins/videoshape/CMakeLists.txt 816ae1d > plugins/videoshape/videoshape.desktop 35a567a > sheets/shape/CMakeLists.txt 9fc7d3c > sheets/shape/spreadsheetshape-deferred.desktop 11479bf > sheets/shape/spreadsheetshape.desktop d578345 > > Diff: http://git.reviewboard.kde.org/r/111265/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
