----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111247/ -----------------------------------------------------------
(Updated June 28, 2013, 1:37 p.m.) Status ------ This change has been marked as submitted. Review request for Calligra. Description ------- As discussed on the ml recently the "Maintainer wanted, alive not dead" splashscreens for Karbon & Plan should be only shown in non-release builds, as plain users will just find them annoying, so possibly have a negative effect on any existing userbase. But there are also other things which are not wanted in release mode: * the plugins which are only in staging mode * devel tools like the textdocument inspector I propose to enable/disable their build globally by a boolean RELEASE_BUILD flag, which either can be set on the commandline or will be estimated by the value of CMAKE_BUILD_TYPE. This can then be used to control the build of the rest. Would any people set RELEASE_BUILD to overwrite the estimated value? Who of you would, for which reason? So should the value rather be cached, or even be stored as an option? Okay to backport to 2.7? (originally written for 2.7, to get rid of the splashscreens in Karbon & Plan for the release) Diffs ----- CMakeLists.txt d21b5a2 cmake/modules/CalligraProductSetMacros.cmake 8e99752 karbon/CMakeLists.txt cf11b06 karbon/main.cpp 4b99283 plan/CMakeLists.txt 7dabf7b plan/main.cpp 23622e7 plugins/textshape/CMakeLists.txt 3bc3628 Diff: http://git.reviewboard.kde.org/r/111247/diff/ Testing ------- Thanks, Friedrich W. H. Kossebau
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
