----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111954/ -----------------------------------------------------------
(Updated Aug. 8, 2013, 8:26 p.m.) Review request for Calligra and Friedrich W. H. Kossebau. Description (updated) ------- Those new product flags define for each top-level application a matching FILTER_<appname> flag. That flag allows to disable all filters for a certain app(s) but it (seems?) they are not evaluated and applied. Following patch works for me in that if I now add something like calligra_disable_product(FILTER_WORDS "Qt5 TODO") calligra_disable_product(FILTER_SHEETS "Qt5 TODO") calligra_disable_product(FILTER_STAGE "Qt5 TODO") to the top-level CMakeLists.txt then all filters for Words, Sheets and Stage are disabled means not build. p.s. an alternate way to solve that could be to e.g. in calligra/CMakeLists.txt - calligra_define_product(FILTER_APPLIXSPREAD_TO_KSPREAD "Applix Spreadsheet to KSpread filter" NEEDS SHEETS_PART) + calligra_define_product(FILTER_APPLIXSPREAD_TO_KSPREAD "Applix Spreadsheet to KSpread filter" NEEDS SHEETS_PART FILTER_SHEETS) What's the prefered way? Diffs ----- filters/CMakeLists.txt 79a42a2 Diff: http://git.reviewboard.kde.org/r/111954/diff/ Testing ------- Note that testing was done with the Qt5-branch. I ask for review (and merge to master) so I get feedback I didn't got something wrong here how those product-flags are supposed to work. Since there are way more such switches I may have to add more such cases here and there and so it would make sense to at least have the initial patch reviewed asap before investing time into solving a not-existing problem and/or a solving it in a wrong way :) Thanks, Sebastian Sauer
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
