----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111960/#review37442 -----------------------------------------------------------
Found what I think is a bug (fallthrough in a case) and some minor formatting issues. krita/plugins/formats/psd/psd.cpp <http://git.reviewboard.kde.org/r/111960/#comment27696> missing break? krita/plugins/formats/psd/psd_image_data.cpp <http://git.reviewboard.kde.org/r/111960/#comment27697> Hmm, indent error or can't the reviewboard show this correctly? krita/plugins/formats/psd/psd_image_data.cpp <http://git.reviewboard.kde.org/r/111960/#comment27698> Calligra uses braces in column 1 at the start of a function. - Inge Wallin On Aug. 9, 2013, 10:22 a.m., Siddharth Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111960/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2013, 10:22 a.m.) > > > Review request for Calligra. > > > Description > ------- > > Patch to support single layered grayscale photoshop documents > > > Diffs > ----- > > kexi/kexiutils/transliteration_table.cpp.orig.bz2 d00dd1d > krita/plugins/formats/psd/psd.cpp 29603b9 > krita/plugins/formats/psd/psd_image_data.h 2fcbcd1 > krita/plugins/formats/psd/psd_image_data.cpp 3c08693 > > Diff: http://git.reviewboard.kde.org/r/111960/diff/ > > > Testing > ------- > > I tested with a grayscale image, it works fine for me > > > Thanks, > > Siddharth Sharma > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
