----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112131/#review38889 -----------------------------------------------------------
I can't say that I understand all the details or implications here. But the fix is very simple and it does look correct. If something strange is discovered later we would have an easy time to fix it. - Inge Wallin On Aug. 17, 2013, 9:21 a.m., C. Boemann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112131/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2013, 9:21 a.m.) > > > Review request for Calligra. > > > Description > ------- > > In the annotation branch, we have made an annotation shape that is subclass > of the textshape. > > And we need for the textshape to be able to be default tool for the > annotation shape as well as the normal textshape > > The solution is for the activationId of toolfactories to be a comma seperated > list of shape ids > > > Diffs > ----- > > libs/flake/KoToolManager.cpp 6134099 > > Diff: http://git.reviewboard.kde.org/r/112131/diff/ > > > Testing > ------- > > i've tested it in the annotation branch where it works flawlessly > > > Thanks, > > C. Boemann > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
