> On Nov. 19, 2013, 2 p.m., Boudewijn Rempt wrote: > > I now get a crash when trying to paste into a text shape in Krita: > > > > Thread 1 (Thread 0x7f16749697c0 (LWP 20528)): > > [KCrash Handler] > > #5 KoShapeController::resourceManager (this=0x0) at > > /home/boud/kde/src/calligra/libs/flake/KoShapeController.cpp:193 > > #6 0x00007f16710d1537 in TextPasteCommand::TextPasteCommand > > (this=0x3c59b00, mimeData=0x380d1e0, document=0xa80d140, > > shapeController=0x0, canvas=0x229f4b0, parent=<optimized out>, > > pasteAsText=false) at > > /home/boud/kde/src/calligra/libs/kotext/commands/TextPasteCommand.cpp:65 > > #7 0x00007f1671001380 in paste (pasteAsText=false, mimeData=0x380d1e0, > > canvas=0x229f4b0, this=0xa80c360) at > > /home/boud/kde/src/calligra/libs/kotext/KoTextEditor.cpp:613 > > #8 KoTextEditor::paste (this=0xa80c360, canvas=0x229f4b0, > > mimeData=0x380d1e0, pasteAsText=false) at > > /home/boud/kde/src/calligra/libs/kotext/KoTextEditor.cpp:601 > > #9 0x00007f165c21f402 in TextTool::paste (this=0xa968fc0) at > > /home/boud/kde/src/calligra/plugins/textshape/TextTool.cpp:1092 > > #10 0x00007f1670cada70 in KoToolProxy::paste (this=0x6600ba0) at > > /home/boud/kde/src/calligra/libs/flake/KoToolProxy.cpp:537 > > #11 0x00007f1673da660c in KisPasteActionFactory::run (this=0x7fffb19377e0, > > view=0x3c15de0) at > > /home/boud/kde/src/calligra/krita/ui/actions/kis_selection_action_factories.cpp:306 > > #12 0x00007f1673c4fa00 in KisSelectionManager::paste (this=0x6c67b70) at > > /home/boud/kde/src/calligra/krita/ui/kis_selection_manager.cc:365 > > #13 0x00007f1673c55535 in qt_static_metacall (_id=9, _o=0x6c67b70, > > _c=<optimized out>, _a=<optimized out>) at > > /home/boud/kde/build/calligra/krita/ui/kis_selection_manager.moc:108 > > #14 KisSelectionManager::qt_static_metacall (_o=0x6c67b70, _c=<optimized > > out>, _id=9, _a=<optimized out>) at > > /home/boud/kde/build/calligra/krita/ui/kis_selection_manager.moc:93 > > #15 0x00007f166c66e29f in QMetaObject::activate(QObject*, QMetaObject > > const*, int, void**) () from /usr/lib64/libQtCore.so.4 > > #16 0x00007f166d2d8662 in QAction::triggered(bool) () from > > /usr/lib64/libQtGui.so.4 > > #17 0x00007f166d2d8850 in QAction::activate(QAction::ActionEvent) () from > > /usr/lib64/libQtGui.so.4 > > #18 0x00007f166d2d89b7 in QAction::event(QEvent*) () from > > /usr/lib64/libQtGui.so.4 > > #19 0x00007f166df17607 in KAction::event(QEvent*) () from > > /usr/lib64/libkdeui.so.5 > > #20 0x00007f166d2de86c in QApplicationPrivate::notify_helper(QObject*, > > QEvent*) () from /usr/lib64/libQtGui.so.4 > > #21 0x00007f166d2e2ceb in QApplication::notify(QObject*, QEvent*) () from > > /usr/lib64/libQtGui.so.4 > > #22 0x00007f16730bf598 in KoApplication::notify (this=<optimized out>, > > receiver=0xa1ba6b0, event=0x7fffb1937f30) at > > /home/boud/kde/src/calligra/libs/main/KoApplication.cpp:549 > > #23 0x00007f166c658d8e in QCoreApplication::notifyInternal(QObject*, > > QEvent*) () from /usr/lib64/libQtCore.so.4 > > #24 0x00007f166d30f524 in ?? () from /usr/lib64/libQtGui.so.4 > > #25 0x00007f166d310b53 in ?? () from /usr/lib64/libQtGui.so.4 > > #26 0x00007f166d2e47ef in QApplication::notify(QObject*, QEvent*) () from > > /usr/lib64/libQtGui.so.4 > > #27 0x00007f16730bf598 in KoApplication::notify (this=<optimized out>, > > receiver=0x20a1120, event=0x7fffb1938510) at > > /home/boud/kde/src/calligra/libs/main/KoApplication.cpp:549 > > #28 0x00007f166c658d8e in QCoreApplication::notifyInternal(QObject*, > > QEvent*) () from /usr/lib64/libQtCore.so.4 > > #29 0x00007f166d37ae8a in ?? () from /usr/lib64/libQtGui.so.4 > > #30 0x00007f166d37b2c1 in ?? () from /usr/lib64/libQtGui.so.4 > > #31 0x00007f166d3589f8 in QApplication::x11ProcessEvent(_XEvent*) () from > > /usr/lib64/libQtGui.so.4 > > #32 0x00007f166d37f9d9 in ?? () from /usr/lib64/libQtGui.so.4 > > #33 0x00007f166c657adf in > > QEventLoop::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from > > /usr/lib64/libQtCore.so.4 > > #34 0x00007f166c657d68 in > > QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from > > /usr/lib64/libQtCore.so.4 > > #35 0x00007f166c65ca08 in QCoreApplication::exec() () from > > /usr/lib64/libQtCore.so.4 > > #36 0x00007f1674309afa in kdemain (argc=<optimized out>, argv=<optimized > > out>) at /home/boud/kde/src/calligra/krita/main.cc:99 > > #37 0x00007f166b4c0a15 in __libc_start_main () from /lib64/libc.so.6 > > #38 0x00000000004009e1 in _start () at ../sysdeps/x86_64/start.S:123 > > > > > > Before, ctrl-v just worked.
right thanks, I see this crash in other apps (besides Words) too. Will fix it tonight. - C. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110821/#review43940 ----------------------------------------------------------- On Nov. 18, 2013, 10:04 p.m., C. Boemann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110821/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2013, 10:04 p.m.) > > > Review request for Calligra. > > > Repository: calligra > > > Description > ------- > > Pasting of images of text and images was broken, because you could only paste > text if the texttool was active, or you could only paste images if the > default tool was active. > > This patch changes it so that pasting of these things is now handled by > toolproxy, so you are able to paste in all cases, unless the active tool > consumes the data. > > > Diffs > ----- > > libs/kotext/tests/TestKoTextEditor.h 60fe599 > libs/kotext/tests/TestKoTextEditor.cpp 75fa075 > plugins/defaultTools/defaulttool/DefaultTool.cpp 68ba881 > plugins/textshape/TextTool.cpp 96294a0 > words/part/KWView.cpp b299234 > libs/flake/KoShapeAnchor.cpp 83087c3 > libs/flake/KoShapePaste.cpp 1457daf > libs/flake/KoToolProxy.cpp 634a1ed > libs/kotext/KoTextEditor.h 9fd3c05 > libs/kotext/KoTextEditor.cpp 40ac427 > libs/kotext/KoTextPaste.h 522ccce > libs/kotext/KoTextPaste.cpp 2304d6a > libs/kotext/commands/ChangeTrackedDeleteCommand.cpp 044fd27 > libs/kotext/commands/TextPasteCommand.h 77d710a > libs/kotext/commands/TextPasteCommand.cpp 34ea25c > libs/kotext/opendocument/KoTextLoader.cpp 7831109 > libs/kotext/opendocument/KoTextSharedLoadingData.h 5ebb7a1 > libs/kotext/opendocument/KoTextSharedLoadingData.cpp d9a73e9 > > Diff: http://git.reviewboard.kde.org/r/110821/diff/ > > > Testing > ------- > > > Thanks, > > C. Boemann > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
