> On Feb. 16, 2014, 9:37 p.m., Andrius da Costa Ribas wrote: > > I've tried this, but I still get the unneeded extra scrollbars in the > > example of Bug 330886. Maybe it needs to compensate the extra left margin > > on Windows?
Thanks for the review. Needs extra testing on windows. The question for now is whether the patch is an improvement or degradation in general. We have not too much time left. - Jarosław ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115537/#review49993 ----------------------------------------------------------- On Feb. 7, 2014, 1:18 p.m., Jarosław Staniek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115537/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2014, 1:18 p.m.) > > > Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam > Pigg, Dimitrios Tanis, Tomasz Olszak, and Radosław Wicik. > > > Bugs: 330885 and 330886 > http://bugs.kde.org/show_bug.cgi?id=330885 > http://bugs.kde.org/show_bug.cgi?id=330886 > > > Repository: calligra > > > Description > ------- > > - Misplaced editor in table view's combo box for right alignment > - Scrollbars sometimes appear in combo box popup even when they are not needed > - Minor margin/padding improvements in table view cells > > > Diffs > ----- > > kexi/widget/tableview/kexicomboboxtableedit.cpp > 599660cfb3b470e899fd52bb6c08eba84cd78c6a > kexi/widget/tableview/kexiinputtableedit.h > 2ac6ee19f6bb49a00d39043ab7f10c1a0a76e0a4 > kexi/widget/tableview/kexiinputtableedit.cpp > 61d9d4929bc5ccb903c9024a5658aa2812b3030a > kexi/widget/tableview/kexitableedit.cpp > d67427505468afe4eb9d001c530ed44f72d341f2 > kexi/widget/tableview/kexitableview.cpp > 4303c3f9fc48ed1986148f1abde3d620c0b83563 > > Diff: https://git.reviewboard.kde.org/r/115537/diff/ > > > Testing > ------- > > Tested on related databases > > > Thanks, > > Jarosław Staniek > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
