> On April 22, 2014, 6:34 p.m., Adam Pigg wrote: > > The code looks littered with casts to q3scrollview. Is this intentional? > > What is the plan for removing them?
This is exactly the "Temporarily wrapped TableView in order to keep it functional" part because this patch focuses on forms. Second part will be devoted to the table view. The casts will disappear then. - Jarosław ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117687/#review56203 ----------------------------------------------------------- On April 22, 2014, noon, Jarosław Staniek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117687/ > ----------------------------------------------------------- > > (Updated April 22, 2014, noon) > > > Review request for Calligra, Andrius da Costa Ribas, Inge Wallin, Oleg > Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, and Radosław Wicik. > > > Repository: calligra > > > Description > ------- > > Port Kexi Forms to Qt4's scroll area from Qt3's Scroll View. This is a > milestone leading to Qt5-based Kexi. > > - Removed KexiScrollView which was a complex and not widely used > generalization of KexiFormScrollView. Removed functionality goes to > KexiFormScrollView. > - Temporarily wrapped TableView in order to keep it functional. > > Porting TableView will go next. > > > Diffs > ----- > > kexi/core/KexiRecordNavigatorIface.h > bb0c13f3ff92f8dd4b4263c2e59c141ef2406de1 > kexi/formeditor/commands.cpp 4a90ab52d90f4c1208896a0bbb32e75f67ca461d > kexi/formeditor/container.cpp 54a6a83fdf5a5b916d85916272ce983774d57c4d > kexi/formeditor/form.h 3dbbe27bdb88ede2c92f9f8d51853b9785d5c63b > kexi/formeditor/form.cpp ee92e84d99a31c4bfd3262ab3244396d70af0d8c > kexi/formeditor/resizehandle.cpp b503261d5c9939d00cdec21a78027ded3b3a7f49 > kexi/plugins/forms/CMakeLists.txt 972456d857c60237ab7d332c6e90859da4d780e2 > kexi/plugins/forms/KexiFormScrollAreaWidget.h PRE-CREATION > kexi/plugins/forms/KexiFormScrollAreaWidget.cpp PRE-CREATION > kexi/plugins/forms/kexiformpart.h 8d670bd43ccde174c1684445b2519b9cd649c72d > kexi/plugins/forms/kexiformpart.cpp > 0cfa59eed4caa46666d250284ebb9503d1ea554e > kexi/plugins/forms/kexiformscrollview.h > fac76070987761c201bb63bc25e7cc2ed32f6b26 > kexi/plugins/forms/kexiformscrollview.cpp > d6120cf663f32c32650a429af42c67cbd18613cd > kexi/plugins/forms/kexiformview.h a58de5e0b82111397852c09a355cf0fd416674b8 > kexi/plugins/forms/kexiformview.cpp > 5cf7053b6f7027bff1edcd00057c8250928bb182 > kexi/plugins/forms/widgets/kexidbform.h > 78da95574207ec2db69f07b4ec10905d50ec90cb > kexi/plugins/forms/widgets/kexidbform.cpp > 7c6f49c3120748ba36a521188fb170972f229426 > kexi/widget/CMakeLists.txt cf6be390218b4e620719acd4bc5e0c6fb19d1531 > kexi/widget/kexiscrollview.h 7c5cc13b72ac0e94f3e242845bfa70ee58c1ab76 > kexi/widget/kexiscrollview.cpp f175f40376c031207c6915c5a736e36ffe383cfb > kexi/widget/tableview/kexitableview.cpp > 212011754c748ca1794bb7ff71acb999944f18b3 > kexi/widget/utils/kexirecordnavigator.h > afc255e82bd4cc66a2c5079959d95f7b14caa40d > kexi/widget/utils/kexirecordnavigator.cpp > 5400578174ad40ceef2ed2fcd287caa951b92dd1 > > Diff: https://git.reviewboard.kde.org/r/117687/diff/ > > > Testing > ------- > > Form and Table views work as before > > > Thanks, > > Jarosław Staniek > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
