----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117790/#review56635 -----------------------------------------------------------
0. Please update the patch based on current calligra master, in one place it doesn't apply cleanly (because of my commit that appeared in the meantime). 1. If this is removal of all traces of Q3, I see 4 lines in widget/relations/ where Q3 is still present. 2. It seems that earlier part of the port to Qt4 isn't complete. Only if I click on header, slotTableViewGotFocus() gets called. If I click on the contents of the QListView, the focus pointer is not transferred so right click does not work at all initially unless I click on one of the table headers. 3. When the context menu finally shows (see 2.) its position is mapped to global coordinates, so appears in wrong place. The pos has to be mapped. - Jarosław Staniek On April 26, 2014, 3:18 p.m., Adam Pigg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117790/ > ----------------------------------------------------------- > > (Updated April 26, 2014, 3:18 p.m.) > > > Review request for Calligra and Jarosław Staniek. > > > Repository: calligra > > > Description > ------- > > Port the relation widget away from q3 support > > Set the context Menu policy of the listview widget to Qt::Custom, and use the > QWidget customContextMenu event. > > > Diffs > ----- > > kexi/widget/relations/CMakeLists.txt > 264a1420643009d872e2bb259ea42c98e9de348e > kexi/widget/relations/KexiRelationsConnection.cpp > 3e8f0c7d1a95473e4ba0a76471fc9b751f54a499 > kexi/widget/relations/KexiRelationsScrollArea.cpp > 0512b3bd5a047950eca9099bf74b8b5530321bae > kexi/widget/relations/KexiRelationsTableContainer.h > 2b48c39ed41c7e7abd267a56223811affd53c443 > kexi/widget/relations/KexiRelationsTableContainer.cpp > e91278f7c51da34a697d0bf514f3414cc356a876 > kexi/widget/relations/KexiRelationsTableContainer_p.cpp > a90d0972e25c7f9c45d4839103637abaf2356959 > > Diff: https://git.reviewboard.kde.org/r/117790/diff/ > > > Testing > ------- > > Checked compiles and that the context menu event is triggered > > > Thanks, > > Adam Pigg > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
