----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117803/#review57087 -----------------------------------------------------------
Good catch, Wojtek! As we can see StaticSetOfStrings is used for optimization (it offers zero mem copy). Summing up, I think 5 separate commits would be ideal: 1, 2, 3: update the lists of keywords (for 3 db engines) -- exactly subject of this review, it's only related to the bug, so add CCBUG:332160 -- please send separate reviews for them 4: case sensitivity but you just found, it's real fix for BUG:332160 - you have it already approved 5: Add a docs in libs/db/utils.cpp saying the string comparison in StaticSetOfStrings::contains() is case sensitive - I can review it via IRC/email - Jarosław Staniek On May 1, 2014, 10:40 p.m., Wojciech Kosowicz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117803/ > ----------------------------------------------------------- > > (Updated May 1, 2014, 10:40 p.m.) > > > Review request for Calligra and Jarosław Staniek. > > > Bugs: 332160 > http://bugs.kde.org/show_bug.cgi?id=332160 > > > Repository: calligra > > > Description > ------- > > words inside keywords.cpp are all capital letters and word that was given to > be checked if it is a kexisql keyword was not changed to capital thefore it > was not filtered > > > Diffs > ----- > > libs/db/driver.cpp efa94e3 > > Diff: https://git.reviewboard.kde.org/r/117803/diff/ > > > Testing > ------- > > Now it is possible to create table, field that is the same sqlite keyword > > > Thanks, > > Wojciech Kosowicz > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
