----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118067/#review57827 -----------------------------------------------------------
Good progress. 1. Please apply this coding style (especially 4 spaces for indentation, no tabs): http://techbase.kde.org/Policies/Kdelibs_Coding_Style 2. You can skip the a.out and helloWorld.class binaries in the next patch. 3. I propose put the code in OdbMigrate.cpp and start implementing the KexiMigrate interface. 4. Qt should be used everywhere in C++, except naturally the JNI calls: QString for unicode, kDebug and kWarning for debugging, etc. kexi/migration/odb/cppWithJni/cppPrg.cpp <https://git.reviewboard.kde.org/r/118067/#comment40255> OK, we need to call method with at least one arg (path to the .odb file) and the method should return bool. In fact we want to be able to ask the java-based reader about error message (string). Also we want to set a number of migrate driver's C++ methods that call the reader's methods so the actual schema and data is created by the driver. Please add a plan for that at http://community.kde.org/Kexi/Junior_Jobs/Add_support_for_importing_tables_from_LibreOffice_Base#Development For example, the C++ driver calls a getTableNames() Java method from implementation of KexiMigrate::drv_tableNames() and returns the result. We always need to check the result of calling. kexi/migration/odb/cppWithJni/cppPrg.cpp <https://git.reviewboard.kde.org/r/118067/#comment40254> missing return with failure here - Jarosław Staniek On May 10, 2014, 12:46 a.m., harshita mistry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118067/ > ----------------------------------------------------------- > > (Updated May 10, 2014, 12:46 a.m.) > > > Review request for Calligra and Jarosław Staniek. > > > Repository: calligra > > > Description > ------- > > A cpp program with jni that calls a java program. > > > Diffs > ----- > > kexi/migration/odb/cppWithJni/helloWorld.java PRE-CREATION > kexi/migration/odb/cppWithJni/helloWorld.class PRE-CREATION > kexi/migration/odb/cppWithJni/cppPrg.cpp PRE-CREATION > kexi/migration/odb/cppWithJni/a.out PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/118067/diff/ > > > Testing > ------- > > > Thanks, > > harshita mistry > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
