----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117966/#review58036 -----------------------------------------------------------
Much better. But after starting ./sql_keywords.sh /tmp/sqlite-src-3080403.zip /tmp/mysql-5.6.17.tar.gz /tmp/postgresql-9.3.4.tar.gz my results are these files in kexi/tools/sql_keywords/: # kexi.all # keywords.cpp # mysql-5.6.17.all # mysql-5.6.17.new # mysqlkeywords.cpp # postgresql-9.3.4.all # postgresql-9.3.4.new # pqxxkeywords.cpp # sqlite-src-3080403.all # sqlite-src-3080403.new # sqlitekeywords.cpp I think when the script finishes (after success or failure) we'd like to have no temp files at all and the *keywords.cpp files in the final destinations. - Jarosław Staniek On May 14, 2014, 11:08 p.m., Wojciech Kosowicz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117966/ > ----------------------------------------------------------- > > (Updated May 14, 2014, 11:08 p.m.) > > > Review request for Calligra and Jarosław Staniek. > > > Repository: calligra > > > Description > ------- > > This patch contains changes for sql_keywords.sh script that generates source > files that contains keywords for specific database technology (kexisql, > sqlite, postrsql, mysql). > I did my best still I think functions getPostgreSQLKeywords and > getSQLiteKeywords can be done in a better (old mechanism did not work but I > think there can be better ways than what I came up with. > Every suggestions are welcome > TODO: > updating comments as some functions changed names/attributes > > > Diffs > ----- > > kexi/tools/sql_keywords/sql_keywords.sh 6bcc5de > > Diff: https://git.reviewboard.kde.org/r/117966/diff/ > > > Testing > ------- > > 4 files that contained keywords are generated and they do contain them > > > Thanks, > > Wojciech Kosowicz > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
