> On June 4, 2014, 9:08 p.m., Adam Pigg wrote: > > I was wondering....this seems like it would suit a unit-test. I know we > > arent set up for unit-test yet but we could start somewhere. 2 tests could > > show a valid query passing, and an incorrect query returning the > > appropriate failure. Then in the future, we know that future changes wont > > break.
Yep, this advice is always fine. Predicate is such a tested place. While porting any KexiDB commit (that relates to an SQL) to Predicate, appropriate test is added: http://quickgit.kde.org/?p=predicate.git&a=blob&h=ec459452ce976399fe1b2db016283b439e8a7c04&hb=f2b7e5e449b41b7b0dc6fa6682740d06665af78f&f=Predicate%2Fparser%2Ftests%2Fdata%2Fstatements.txt Functional test based on switching between query views would be added at some point to Kexi itself. - Jarosław ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118519/#review59245 ----------------------------------------------------------- On June 4, 2014, 11:16 a.m., Jarosław Staniek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118519/ > ----------------------------------------------------------- > > (Updated June 4, 2014, 11:16 a.m.) > > > Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam > Pigg, Dimitrios Tanis, Tomasz Olszak, Radosław Wicik, and Wojciech Kosowicz. > > > Bugs: 315852 > http://bugs.kde.org/show_bug.cgi?id=315852 > > > Repository: calligra > > > Description > ------- > > Fix crash when accessing a query with duplicated table names > > Example query that crashed: SELECT t.foo FROM t, t. > Now error message is displayed so user can fix the statement. > > FIXED-IN:2.8.4 > > > Diffs > ----- > > libs/db/expression.cpp c59855e1e9e4b972352b58b2037c9187a251ed8f > > Diff: https://git.reviewboard.kde.org/r/118519/diff/ > > > Testing > ------- > > No longer crashes for tested queries, we're no longer using dangerous > function at() in this context > > > Thanks, > > Jarosław Staniek > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
