----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119075/#review62023 -----------------------------------------------------------
Almost there! kexi/plugins/reports/kexireportview.cpp <https://git.reviewboard.kde.org/r/119075/#comment43155> Extension is missing. It's good to have extra 'extension' arg here, set to "pdf" for example. I know the KDE dialog added extensions automatically but on Windows it may not be the case. kexi/plugins/reports/kexireportview.cpp <https://git.reviewboard.kde.org/r/119075/#comment43153> 1. coding style! -use space after keyword -use {} block 2. !lastExportPath.isEmpty() not needed, startsWith() is safe on empty strings 3. startsWith(const QString &s, bool cs) comes from Qt 3, use startsWith ( const QString& ) - Jarosław Staniek On July 9, 2014, 7:44 p.m., Wojciech Kosowicz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119075/ > ----------------------------------------------------------- > > (Updated July 9, 2014, 7:44 p.m.) > > > Review request for Calligra and Jarosław Staniek. > > > Bugs: 335150 > http://bugs.kde.org/show_bug.cgi?id=335150 > > > Repository: calligra > > > Description > ------- > > Added button to report data view that prints report directly to pdf after > selecting location > > > Diffs > ----- > > kexi/plugins/reports/kexireportview.h 1823cf8 > kexi/plugins/reports/kexireportview.cpp 2d84efc > > Diff: https://git.reviewboard.kde.org/r/119075/diff/ > > > Testing > ------- > > After clicking and selecting save location pdf document with report data view > content is created > > > Thanks, > > Wojciech Kosowicz > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
