----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120326/#review67248 -----------------------------------------------------------
Ship it! Good job! - Jarosław Staniek On Sept. 23, 2014, 1:12 a.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120326/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2014, 1:12 a.m.) > > > Review request for Calligra and Jarosław Staniek. > > > Repository: calligra > > > Description > ------- > > `const char *x[]` is still a variable, being an array of non-const pointers > to const chars, `x[2] = anotherconststring;` is still possible. > `const char * const x[]` is a const itself, `x[2] = anotherconststring;` no > longer possible. And is one indirection less when accessing the data, because > x is now the symbol of the actual data and not of the variable keeping the > address of the actual data. > > > Diffs > ----- > > kexi/kexidb/drivers/mysql/mysqldriver.h 9eb1813 > kexi/kexidb/drivers/mysql/mysqlkeywords.cpp f1dbde5 > kexi/kexidb/drivers/oracle/oracle_keywords.sh 49a627f > kexi/kexidb/drivers/oracle/oracledriver.h 11ee497 > kexi/kexidb/drivers/oracle/oraclekeywords.cpp 2163690 > kexi/kexidb/drivers/pqxx/pqxxdriver.h b8b513f > kexi/kexidb/drivers/pqxx/pqxxkeywords.cpp 4bac74a > kexi/kexidb/drivers/sybase/sybasedriver.h 196c08b > kexi/kexidb/drivers/sybase/sybasekeywords.cpp 0071da3 > kexi/kexidb/drivers/xbase/xbasedriver.h 1281cd0 > kexi/kexidb/drivers/xbase/xbasekeywords.cpp 7c1c42b > kexi/tools/sql_keywords/sql_keywords.sh be4eeed > libs/db/driver.h f041c20 > libs/db/driver.cpp d6b4610 > libs/db/driver_p.h 7f8ccea > libs/db/drivers/sqlite/sqlitedriver.h 92c011d > libs/db/drivers/sqlite/sqlitekeywords.cpp 04ca0f0 > libs/db/keywords.cpp 03c44d1 > libs/db/utils.h 01e27cf > libs/db/utils.cpp 8414217 > > Diff: https://git.reviewboard.kde.org/r/120326/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
